Revision: 15474
http://sourceforge.net/p/skim-app/code/15474
Author: hofman
Date: 2025-06-16 21:26:11 +0000 (Mon, 16 Jun 2025)
Log Message:
-----------
return presentation undo manager only when it was needed
Modified Paths:
--------------
trunk/SKMainWindowController.h
trunk/SKMainWindowController.m
trunk/SKMainWindowController_UI.m
Modified: trunk/SKMainWindowController.h
===================================================================
--- trunk/SKMainWindowController.h 2025-06-16 16:56:44 UTC (rev 15473)
+++ trunk/SKMainWindowController.h 2025-06-16 21:26:11 UTC (rev 15474)
@@ -256,8 +256,6 @@
@property (nonatomic, nullable, weak) NSDocument *presentationNotesDocument;
@property (nonatomic) NSInteger presentationNotesOffset;
-@property (nonatomic, nullable, readonly) NSUndoManager
*presentationUndoManager;
-
@property (nonatomic, copy) NSArray<NSString *> *tags;
@property (nonatomic) double rating;
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2025-06-16 16:56:44 UTC (rev 15473)
+++ trunk/SKMainWindowController.m 2025-06-16 21:26:11 UTC (rev 15474)
@@ -214,7 +214,7 @@
@implementation SKMainWindowController
@synthesize splitView, topConstraint, centerContentView, pdfSplitView,
pdfContentView, findBarTopConstraint, statusBar, pdfView, secondaryPdfView,
leftSideContentView, rightSideContentView, presentationNotesDocument,
presentationNotesOffset, notes, thumbnails, snapshots, searchResults,
groupedSearchResults, tags, rating, pageLabel, interactionMode,
placeholderPdfDocument;
-@dynamic pdfDocument, presentationUndoManager, selectedNotes, hasNotes,
widgetProperties, currentPage, leftSidePaneState, rightSidePaneState,
findPaneState, displaysFindPane, leftSidePaneIsOpen, rightSidePaneIsOpen,
searchString, hasNoteToolbar, hasOverview, notesMenu;
+@dynamic pdfDocument, selectedNotes, hasNotes, widgetProperties, currentPage,
leftSidePaneState, rightSidePaneState, findPaneState, displaysFindPane,
leftSidePaneIsOpen, rightSidePaneIsOpen, searchString, hasNoteToolbar,
hasOverview, notesMenu;
+ (BOOL)automaticallyNotifiesObserversOfPageLabel { return NO; }
Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m 2025-06-16 16:56:44 UTC (rev 15473)
+++ trunk/SKMainWindowController_UI.m 2025-06-16 21:26:11 UTC (rev 15474)
@@ -92,6 +92,7 @@
#import "SKPresentationView.h"
#import "SKBookmarkController.h"
#import "SKNoteToolbarController.h"
+#import "SKPresentationNotesAuxiliary.h"
#define NOTES_KEY @"notes"
#define SNAPSHOTS_KEY @"snapshots"
@@ -327,9 +328,10 @@
}
- (NSUndoManager *)windowWillReturnUndoManager:(NSWindow *)window {
+ NSUndoManager *undoManager = nil;
if ([self interactionMode] == SKPresentationMode)
- return [self presentationUndoManager];
- return [[self document] undoManager];
+ undoManager = [presentationNotesAuxiliary undoManager];
+ return undoManager ?: [[self document] undoManager];
}
- (void)window:(NSWindow *)window willSendEvent:(NSEvent *)event {
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
