Revision: 15495
http://sourceforge.net/p/skim-app/code/15495
Author: hofman
Date: 2025-06-18 15:42:54 +0000 (Wed, 18 Jun 2025)
Log Message:
-----------
rename method
Modified Paths:
--------------
trunk/SKMainDocument.m
Modified: trunk/SKMainDocument.m
===================================================================
--- trunk/SKMainDocument.m 2025-06-18 15:25:25 UTC (rev 15494)
+++ trunk/SKMainDocument.m 2025-06-18 15:42:54 UTC (rev 15495)
@@ -299,7 +299,7 @@
return option;
}
-- (BOOL)discontinueAfterFailureToReadNotesFromURL:(NSURL *)aURL error:(NSError
*)error {
+- (BOOL)shouldDiscontinueAfterReadNotesError:(NSError *)error fromURL:(NSURL
*)aURL {
NSAlert *alert = [[NSAlert alloc] init];
[alert setMessageText:NSLocalizedString(@"Unable to Read Notes", @"Message
in alert dialog")];
[alert setInformativeText:[NSString
stringWithFormat:NSLocalizedString(@"Skim was not able to read the notes at %@.
%@ Do you want to continue to open the PDF document anyway?", @"Informative
text in alert dialog"), [[aURL path] stringByAbbreviatingWithTildeInPath],
[error localizedDescription]]];
@@ -912,7 +912,7 @@
NSArray *array = [[NSFileManager defaultManager]
readSkimNotesFromPDFBundleAtURL:absoluteURL error:&error];
if ([array count]) {
[tmpData setNoteDicts:array];
- } else if (array == nil && [self
discontinueAfterFailureToReadNotesFromURL:absoluteURL error:error]) {
+ } else if (array == nil && [self
shouldDiscontinueAfterReadNotesError:error fromURL:absoluteURL]) {
data = nil;
pdfDoc = nil;
error = [NSError
userCancelledErrorWithUnderlyingError:error];
@@ -933,7 +933,7 @@
// if we found no notes, see if we had an error finding notes. If
EAs were not supported we ignore the error, as we may assume there won't be any
notes
if (foundEANotes) {
[tmpData setNoteDicts:array];
- } else if (array == nil && isIgnorablePOSIXError(error) == NO &&
[self discontinueAfterFailureToReadNotesFromURL:absoluteURL error:error]) {
+ } else if (array == nil && isIgnorablePOSIXError(error) == NO &&
[self shouldDiscontinueAfterReadNotesError:error fromURL:absoluteURL]) {
fileData = nil;
data = nil;
pdfDoc = nil;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
