[Skim-app-commit] SF.net SVN: skim-app:[15565] trunk/SKMainDocument.m

[hofman--- via Skim-app-commit]

Revision: 15565
          http://sourceforge.net/p/skim-app/code/15565
Author:   hofman
Date:     2025-06-29 16:10:02 +0000 (Sun, 29 Jun 2025)
Log Message:
-----------
create tmpData only when needed

Modified Paths:
--------------
    trunk/SKMainDocument.m

Modified: trunk/SKMainDocument.m
===================================================================
--- trunk/SKMainDocument.m      2025-06-29 16:06:55 UTC (rev 15564)
+++ trunk/SKMainDocument.m      2025-06-29 16:10:02 UTC (rev 15565)
@@ -881,8 +881,6 @@
     PDFDocument *pdfDoc = nil;
     NSError *error = nil;
     
-    tmpData = [[SKTemporaryData alloc] init];
-    
     if ([[NSWorkspace sharedWorkspace] type:docType 
conformsToType:SKDocumentTypePostScript]) {
         inData = data;
         data = [SKConversionProgressController 
newPDFDataWithPostScriptData:data error:&error];
@@ -892,13 +890,13 @@
         pdfDoc = [[SKPDFDocument alloc] initWithData:data];
     
     if (pdfDoc) {
+        tmpData = [[SKTemporaryData alloc] init];
+        [tmpData setPdfDocument:pdfDoc];
         [self setPDFData:data];
-        [tmpData setPdfDocument:pdfDoc];
         [self setOriginalData:inData];
         [self updateChangeCount:NSChangeReadOtherContents];
         return YES;
     } else {
-        tmpData = nil;
         if (outError != NULL)
             *outError = error ?: [NSError 
readFileErrorWithLocalizedDescription:NSLocalizedString(@"Unable to load file", 
@"Error description")];
         return NO;

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit