Revision: 15568 http://sourceforge.net/p/skim-app/code/15568 Author: hofman Date: 2025-06-29 17:12:02 +0000 (Sun, 29 Jun 2025) Log Message: ----------- no need for convenience method
Modified Paths: -------------- trunk/SKPDFView.m Modified: trunk/SKPDFView.m =================================================================== --- trunk/SKPDFView.m 2025-06-29 16:38:51 UTC (rev 15567) +++ trunk/SKPDFView.m 2025-06-29 17:12:02 UTC (rev 15568) @@ -937,10 +937,6 @@ return undoManager; } -- (void)setUndoActionName:(NSString *)actionName { - [[self undoManager] setActionName:actionName]; -} - - (BOOL)canSelectNote { return hideNotes == NO && (toolMode == SKToolModeText || toolMode == SKToolModeNote) && [[self document] allowsNotes]; } @@ -1254,7 +1250,7 @@ } - [self setUndoActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; } else { @@ -1322,7 +1318,7 @@ [newAnnotation registerUserName]; [self beginNewUndoGroupIfNeededWithCommit:YES]; [[self document] addAnnotation:newAnnotation toPage:page]; - [self setUndoActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; if (toolMode == SKToolModeText || toolMode == SKToolModeNote) [self setCurrentAnnotation:newAnnotation]; @@ -1366,7 +1362,7 @@ [newAnnotation registerUserName]; [self beginNewUndoGroupIfNeededWithCommit:YES]; [[self document] addAnnotation:newAnnotation toPage:page]; - [self setUndoActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; if (toolMode == SKToolModeText || toolMode == SKToolModeNote) [self setCurrentAnnotation:newAnnotation]; @@ -2313,7 +2309,7 @@ [newAnnotation registerUserName]; [self beginNewUndoGroupIfNeededWithCommit:YES]; [[self document] addAnnotation:newAnnotation toPage:page]; - [self setUndoActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; if (toolMode == SKToolModeText || toolMode == SKToolModeNote) [self setCurrentAnnotation:newAnnotation]; @@ -2460,7 +2456,7 @@ [newAnnotation registerUserName]; [[self document] addAnnotation:newAnnotation toPage:page]; } - [self setUndoActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; if (toolMode == SKToolModeText || toolMode == SKToolModeNote) [self setCurrentAnnotation:newAnnotation]; @@ -2479,7 +2475,7 @@ [newAnnotation setString:@""]; [newAnnotation registerUserName]; [[self document] addAnnotation:newAnnotation toPage:page]; - [self setUndoActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; if (toolMode == SKToolModeText || toolMode == SKToolModeNote) [self setCurrentAnnotation:newAnnotation]; @@ -2675,7 +2671,7 @@ - (void)removeCurrentAnnotation:(id)sender{ if ([currentAnnotation isSkimNote]) { [[self document] removeAnnotation:currentAnnotation]; - [self setUndoActionName:NSLocalizedString(@"Remove Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Remove Note", @"Undo action name")]; } } @@ -3795,7 +3791,7 @@ if (newActivePage != [currentAnnotation page]) { // move the annotation to the new page [[self document] moveAnnotation:currentAnnotation toPage:newActivePage]; - [self setUndoActionName:NSLocalizedString(@"Edit Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Edit Note", @"Undo action name")]; } NSRect newBounds = [currentAnnotation bounds]; @@ -4180,7 +4176,7 @@ [newAnnotation registerUserName]; [self beginNewUndoGroupIfNeededWithCommit:YES]; [[self document] addAnnotation:newAnnotation toPage:page]; - [self setUndoActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; newCurrentAnnotation = newAnnotation; } else if (([newCurrentAnnotation isMarkup] || (isInk && (newCurrentAnnotation != currentAnnotation || (modifiers & (NSEventModifierFlagShift | NSEventModifierFlagCapsLock))))) && @@ -4234,7 +4230,7 @@ [[self document] removeAnnotation:newCurrentAnnotation]; [self removeCurrentAnnotation:nil]; [[self document] addAnnotation:newAnnotation toPage:page]; - [self setUndoActionName:NSLocalizedString(@"Join Notes", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Join Notes", @"Undo action name")]; newCurrentAnnotation = newAnnotation; } } @@ -4379,7 +4375,7 @@ [annotation registerUserName]; [self beginNewUndoGroupIfNeededWithCommit:NO]; [[self document] addAnnotation:annotation toPage:page]; - [self setUndoActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Add Note", @"Undo action name")]; if (currentAnnotation) { [self removeCurrentAnnotation:nil]; @@ -4406,7 +4402,7 @@ for (PDFAnnotation *annotation in annotations) { if ([annotation isSkimNote] && [annotation hitTest:point] && [self isEditingAnnotation:annotation] == NO) { [[self document] removeAnnotation:annotation]; - [self setUndoActionName:NSLocalizedString(@"Remove Note", @"Undo action name")]; + [[self undoManager] setActionName:NSLocalizedString(@"Remove Note", @"Undo action name")]; break; } } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. _______________________________________________ Skim-app-commit mailing list Skim-app-commit@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/skim-app-commit