[Skim-app-commit] SF.net SVN: skim-app:[15633] trunk/SKPDFView.m

[hofman--- via Skim-app-commit]

Revision: 15633
          http://sourceforge.net/p/skim-app/code/15633
Author:   hofman
Date:     2025-07-10 15:52:14 +0000 (Thu, 10 Jul 2025)
Log Message:
-----------
avoid converting rect back and forth from page

Modified Paths:
--------------
    trunk/SKPDFView.m

Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m   2025-07-10 14:47:03 UTC (rev 15632)
+++ trunk/SKPDFView.m   2025-07-10 15:52:14 UTC (rev 15633)
@@ -4765,7 +4765,7 @@
     NSRect rect = [self convertRect:selRect fromView:[self documentView]];
     NSRect bounds;
     NSInteger factor = 1;
-    BOOL autoFits = NO;
+    BOOL autoFits = YES;
     
     if (dragged) {
     
@@ -4790,14 +4790,11 @@
             if (NSMaxX(rect) > NSMaxY(bounds))
                 rect.origin.y = NSMaxY(bounds) - NSHeight(rect);
         }
+        rect = [self convertRect:rect toPage:page];
         
-        autoFits = YES;
-        
     } else if (toolMode == SKToolModeSelect && NSIsEmptyRect(selectionRect) == 
NO) {
         
         rect = NSIntersectionRect(selectionRect, [page 
boundsForBox:kPDFDisplayBoxCropBox]);
-        rect = [self convertRect:rect fromPage:page];
-        autoFits = YES;
         
     } else {
         
@@ -4815,11 +4812,14 @@
         rect = [self convertRect:[page boundsForBox:kPDFDisplayBoxCropBox] 
fromPage:page];
         rect.origin.y = point.y - 0.5 * DEFAULT_SNAPSHOT_HEIGHT;
         rect.size.height = DEFAULT_SNAPSHOT_HEIGHT;
+        rect = [self convertRect:rect toPage:page];
         
+        autoFits = NO;
+        
     }
     
     if ([[self delegate] 
respondsToSelector:@selector(PDFView:showSnapshotAtPageNumber:forRect:scaleFactor:autoFits:)])
-        [[self delegate] PDFView:self showSnapshotAtPageNumber:[page 
pageIndex] forRect:[self convertRect:rect toPage:page] scaleFactor:[self 
scaleFactor] * factor autoFits:autoFits];
+        [[self delegate] PDFView:self showSnapshotAtPageNumber:[page 
pageIndex] forRect:rect scaleFactor:[self scaleFactor] * factor 
autoFits:autoFits];
 }
 
 - (void)removeLoupeWindow {

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit