Revision: 15666
          http://sourceforge.net/p/skim-app/code/15666
Author:   hofman
Date:     2025-07-17 08:53:45 +0000 (Thu, 17 Jul 2025)
Log Message:
-----------
don't set conditionally editable option for author field, it is always editable

Modified Paths:
--------------
    trunk/RightSideView.xib
    trunk/SKMainWindowController_UI.m

Modified: trunk/RightSideView.xib
===================================================================
--- trunk/RightSideView.xib     2025-07-17 08:48:02 UTC (rev 15665)
+++ trunk/RightSideView.xib     2025-07-17 08:53:45 UTC (rev 15666)
@@ -285,7 +285,11 @@
                                                     <color 
key="backgroundColor" name="controlColor" catalog="System" 
colorSpace="catalog"/>
                                                 </textFieldCell>
                                                 <connections>
-                                                    <binding 
destination="I4N-kX-XRY" name="value" keyPath="objectValue.userName" 
id="wY0-NB-x0w"/>
+                                                    <binding 
destination="I4N-kX-XRY" name="value" keyPath="objectValue.userName" 
id="NUe-EE-ODN">
+                                                        <dictionary 
key="options">
+                                                            <bool 
key="NSConditionallySetsEditable" value="NO"/>
+                                                        </dictionary>
+                                                    </binding>
                                                 </connections>
                                             </textField>
                                         </subviews>

Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m   2025-07-17 08:48:02 UTC (rev 15665)
+++ trunk/SKMainWindowController_UI.m   2025-07-17 08:53:45 UTC (rev 15666)
@@ -1419,6 +1419,7 @@
 }
 
 - (BOOL)commitEditingAndReturnError:(NSError **)error {
+    // there are no validations of the edited value, so we will always succeed
     BOOL rv = [pdfView commitEditing];
     id firstResponder = [[self window] firstResponder];
     if ([firstResponder isKindOfClass:[NSText class]] && [firstResponder 
isDescendantOf:rightSideController.noteOutlineView])

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to