Revision: 15678
http://sourceforge.net/p/skim-app/code/15678
Author: hofman
Date: 2025-10-02 15:53:38 +0000 (Thu, 02 Oct 2025)
Log Message:
-----------
Add deignated initializer attributes
Modified Paths:
--------------
trunk/SKAlias.h
trunk/SKChainedUndoManager.h
trunk/SKColorMenuView.h
trunk/SKDisplayPrefs.h
trunk/SKDownload.h
trunk/SKGroupedSearchResult.h
trunk/SKLine.h
trunk/SKNotePrefs.h
trunk/SKNoteText.h
trunk/SKPDFSyncRecord.h
trunk/SKReadingBar.h
trunk/SKShareMenuController.h
trunk/SKShareMenuController.m
trunk/SKSnapshotConfiguration.h
trunk/SKSyncDot.h
trunk/SKTemplateTag.h
trunk/SKTextNoteEditor.h
trunk/SKThumbnail.h
trunk/SKThumbnailStamp.h
trunk/SKTransitionInfo.h
trunk/SKTransitionInfo.m
trunk/SKTypeSelectHelper.h
trunk/SKVersionNumber.h
Modified: trunk/SKAlias.h
===================================================================
--- trunk/SKAlias.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKAlias.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -50,9 +50,10 @@
@property (nonatomic, nullable, readonly) NSURL *fileURL;
@property (nonatomic, nullable, readonly) NSURL *fileURLNoUI;
-- (nullable instancetype)initWithAliasData:(NSData *)data;
-- (nullable instancetype)initWithBookmarkData:(NSData *)data;
+- (nullable instancetype)initWithAliasData:(NSData *)data
NS_DESIGNATED_INITIALIZER;
+- (nullable instancetype)initWithBookmarkData:(NSData *)data
NS_DESIGNATED_INITIALIZER;
- (nullable instancetype)initWithURL:(NSURL *)fileURL;
+- (instancetype)init NS_UNAVAILABLE;
@end
Modified: trunk/SKChainedUndoManager.h
===================================================================
--- trunk/SKChainedUndoManager.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKChainedUndoManager.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -43,7 +43,8 @@
@interface SKChainedUndoManager : NSUndoManager {
NSUndoManager *nextUndoManager;
}
-- (instancetype)initWithNextUndoManager:(NSUndoManager *)undoManager;
+- (instancetype)initWithNextUndoManager:(NSUndoManager *)undoManager
NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
@end
NS_ASSUME_NONNULL_END
Modified: trunk/SKColorMenuView.h
===================================================================
--- trunk/SKColorMenuView.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKColorMenuView.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -49,7 +49,9 @@
NSUInteger hoveredIndex;
}
-- (instancetype)initWithAnnotation:(PDFAnnotation *)anAnnotation;
+- (instancetype)initWithAnnotation:(PDFAnnotation *)anAnnotation
NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithFrame:(NSRect)frameRect NS_UNAVAILABLE;
+- (instancetype)initWithCoder:(NSCoder *)coder NS_UNAVAILABLE;
@end
Modified: trunk/SKDisplayPrefs.h
===================================================================
--- trunk/SKDisplayPrefs.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKDisplayPrefs.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -51,8 +51,9 @@
@property (nonatomic, nullable, strong) NSColor *whitePoint;
@property (nonatomic, getter=isInverted) BOOL inverted;
-- (instancetype)initForFullScreen:(BOOL)isFullScreen;
+- (instancetype)initForFullScreen:(BOOL)isFullScreen NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithName:(NSString *)name;
+- (instancetype)init NS_UNAVAILABLE;
@end
Modified: trunk/SKDownload.h
===================================================================
--- trunk/SKDownload.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKDownload.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -104,8 +104,9 @@
@property (class, nonatomic, readonly) NSImage *cancelImage;
@property (class, nonatomic, readonly) NSImage *resumeImage;
-- (instancetype)initWithURL:(nullable NSURL *)aURL;
+- (instancetype)initWithURL:(nullable NSURL *)aURL NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithProperties:(NSDictionary<NSString *, id> *)properties;
+- (instancetype)init NS_UNAVAILABLE;
- (void)start;
- (void)cancel;
Modified: trunk/SKGroupedSearchResult.h
===================================================================
--- trunk/SKGroupedSearchResult.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKGroupedSearchResult.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -56,7 +56,8 @@
@property (weak, nonatomic, readonly) NSString *label;
@property (nonatomic, readonly) NSArray<PDFSelection *> *matches;
-- (instancetype)initWithPage:(PDFPage *)aPage maxCount:(NSUInteger)aMaxCount;
+- (instancetype)initWithPage:(PDFPage *)aPage maxCount:(NSUInteger)aMaxCount
NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
- (void)addMatch:(PDFSelection *)match;
Modified: trunk/SKLine.h
===================================================================
--- trunk/SKLine.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKLine.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -47,7 +47,8 @@
NSInteger index;
}
-- (instancetype)initWithPage:(PDFPage *)aPage index:(NSInteger)anIndex;
+- (instancetype)initWithPage:(PDFPage *)aPage index:(NSInteger)anIndex
NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
@property (nonatomic, readonly) PDFPage *page;
@property (nonatomic, readonly) NSInteger index;
Modified: trunk/SKNotePrefs.h
===================================================================
--- trunk/SKNotePrefs.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKNotePrefs.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -61,7 +61,8 @@
@property (nonatomic, nullable, strong) NSString *scriptingUserName;
@property (nonatomic, strong) NSDictionary<NSString *, id>
*scriptingProperties;
-- (nullable instancetype)initWithType:(NSString *)aType;
+- (nullable instancetype)initWithType:(NSString *)aType
NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
@end
Modified: trunk/SKNoteText.h
===================================================================
--- trunk/SKNoteText.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKNoteText.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -45,7 +45,8 @@
__weak PDFAnnotation *note;
}
-- (instancetype)initWithNote:(PDFAnnotation *)aNote;
+- (instancetype)initWithNote:(PDFAnnotation *)aNote NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
@property (nonatomic, weak, readonly) PDFAnnotation *note;
Modified: trunk/SKPDFSyncRecord.h
===================================================================
--- trunk/SKPDFSyncRecord.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKPDFSyncRecord.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -55,7 +55,8 @@
@property (nonatomic, nullable, strong) NSString *file;
@property (nonatomic) NSInteger line;
-- (instancetype)initWithRecordIndex:(NSInteger)aRecordIndex;
+- (instancetype)initWithRecordIndex:(NSInteger)aRecordIndex
NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
@end
Modified: trunk/SKReadingBar.h
===================================================================
--- trunk/SKReadingBar.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKReadingBar.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -61,7 +61,8 @@
@property (readonly) NSRect currentBounds;
@property (nonatomic, nullable, weak) id <SKReadingBarDelegate> delegate;
-- (instancetype)initWithPage:(nullable PDFPage *)aPage line:(NSInteger)line
delegate:(nullable id <SKReadingBarDelegate>)aDelegate;
+- (instancetype)initWithPage:(nullable PDFPage *)aPage line:(NSInteger)line
delegate:(nullable id <SKReadingBarDelegate>)aDelegate
NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
- (BOOL)goToNextLine;
- (BOOL)goToPreviousLine;
Modified: trunk/SKShareMenuController.h
===================================================================
--- trunk/SKShareMenuController.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKShareMenuController.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -44,7 +44,8 @@
__weak NSDocument *document;
}
-- (instancetype)initForDocument:(nullable NSDocument *)aDocument;
+- (instancetype)initForDocument:(nullable NSDocument *)aDocument
NS_DESIGNATED_INITIALIZER;
+- (nullable instancetype)initWithCoder:(NSCoder *)coder NS_UNAVAILABLE;
@property (nonatomic, nullable, weak) NSDocument *document;
Modified: trunk/SKShareMenuController.m
===================================================================
--- trunk/SKShareMenuController.m 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKShareMenuController.m 2025-10-02 15:53:38 UTC (rev 15678)
@@ -54,6 +54,11 @@
return self;
}
+- (instancetype)init {
+ self = [self initForDocument:nil];
+ return self;
+}
+
- (instancetype)initWithCoder:(NSCoder *)coder {
self = nil;
return nil;
Modified: trunk/SKSnapshotConfiguration.h
===================================================================
--- trunk/SKSnapshotConfiguration.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKSnapshotConfiguration.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -49,7 +49,8 @@
NSArray<PDFDestination *> *pages;
}
-- (instancetype)initWithPDFView:(PDFView *)pdfView;
+- (instancetype)initWithPDFView:(PDFView *)pdfView NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
- (NSImage *)thumbnailWithSize:(CGFloat)aSize scale:(CGFloat)scale;
- (NSImage *)placeholderThumbnailWithSize:(CGFloat)aSize scale:(CGFloat)scale;
Modified: trunk/SKSyncDot.h
===================================================================
--- trunk/SKSyncDot.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKSyncDot.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -58,7 +58,8 @@
@property (nonatomic, readonly) NSRect bounds;
@property (nonatomic) BOOL shouldHideReadingBar;
-- (instancetype)initWithPoint:(NSPoint)aPoint page:(PDFPage *)aPage
updateHandler:(SKSyncDotUpdateBlock)aHandler;
+- (instancetype)initWithPoint:(NSPoint)aPoint page:(PDFPage *)aPage
updateHandler:(SKSyncDotUpdateBlock)aHandler NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
- (void)invalidate;
Modified: trunk/SKTemplateTag.h
===================================================================
--- trunk/SKTemplateTag.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKTemplateTag.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -73,7 +73,8 @@
NSString *keyPath;
}
-- (instancetype)initWithKeyPath:(NSString *)aKeyPath;
+- (instancetype)initWithKeyPath:(NSString *)aKeyPath NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
@property (nonatomic, readonly) NSString *keyPath;
@@ -86,7 +87,8 @@
SKAttributeTemplate *linkTemplate;
}
-- (instancetype)initWithKeyPath:(NSString *)aKeyPath
attributes:(NSDictionary<NSString *, id> *)anAttributes;
+- (instancetype)initWithKeyPath:(NSString *)aKeyPath
attributes:(NSDictionary<NSString *, id> *)anAttributes
NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithKeyPath:(NSString *)aKeyPath NS_UNAVAILABLE;
@property (nonatomic, readonly) NSDictionary<NSString *, id> *attributes;
@property (nonatomic, nullable, readonly) SKAttributeTemplate *linkTemplate;
@@ -102,7 +104,8 @@
NSArray<__kindof SKTemplateTag *> *separatorTemplate;
}
-- (instancetype)initWithKeyPath:(NSString *)aKeyPath
itemTemplateString:(NSString *)anItemTemplateString
separatorTemplateString:(nullable NSString *)aSeparatorTemplateString;
+- (instancetype)initWithKeyPath:(NSString *)aKeyPath
itemTemplateString:(NSString *)anItemTemplateString
separatorTemplateString:(nullable NSString *)aSeparatorTemplateString
NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithKeyPath:(NSString *)aKeyPath NS_UNAVAILABLE;
@property (nonatomic, nullable, readonly) NSArray<__kindof SKTemplateTag *>
*itemTemplate, *separatorTemplate;
@@ -117,7 +120,8 @@
NSArray<__kindof SKTemplateTag *> *separatorTemplate;
}
-- (instancetype)initWithKeyPath:(NSString *)aKeyPath
itemTemplateAttributedString:(NSAttributedString
*)anItemTemplateAttributedString separatorTemplateAttributedString:(nullable
NSAttributedString *)aSeparatorTemplateAttributedString;
+- (instancetype)initWithKeyPath:(NSString *)aKeyPath
itemTemplateAttributedString:(NSAttributedString
*)anItemTemplateAttributedString separatorTemplateAttributedString:(nullable
NSAttributedString *)aSeparatorTemplateAttributedString
NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithKeyPath:(NSString *)aKeyPath NS_UNAVAILABLE;
@property (nonatomic, nullable, readonly) NSArray<__kindof SKTemplateTag *>
*itemTemplate, *separatorTemplate;
@@ -131,7 +135,8 @@
NSArray<NSString *> *matchStrings;
}
-- (instancetype)initWithKeyPath:(NSString *)aKeyPath
matchType:(SKTemplateTagMatchType)aMatchType matchStrings:(NSArray
*)aMatchStrings subtemplates:(NSArray *)aSubtemplates;
+- (instancetype)initWithKeyPath:(NSString *)aKeyPath
matchType:(SKTemplateTagMatchType)aMatchType matchStrings:(NSArray
*)aMatchStrings subtemplates:(NSArray *)aSubtemplates NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithKeyPath:(NSString *)aKeyPath NS_UNAVAILABLE;
@property (nonatomic, readonly) SKTemplateTagMatchType matchType;
@property (nonatomic, readonly) NSArray<NSString *> *matchStrings;
@@ -152,7 +157,8 @@
NSString *text;
}
-- (instancetype)initWithText:(NSString *)aText;
+- (instancetype)initWithText:(NSString *)aText NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
@property (nonatomic, strong) NSString *text;
@@ -167,7 +173,8 @@
NSArray<NSArray<__kindof SKTemplateTag *> *> *linkTemplates;
}
-- (instancetype)initWithAttributedText:(NSAttributedString *)anAttributedText;
+- (instancetype)initWithAttributedText:(NSAttributedString *)anAttributedText
NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
@property (nonatomic, strong) NSAttributedString *attributedText;
@@ -185,7 +192,7 @@
Class attributeClass;
}
-- (instancetype)initWithTemplate:(nullable NSArray<__kindof SKTemplateTag *>
*)aTemplate range:(NSRange)aRange attributeClass:(Class)aClass;
+- (instancetype)initWithTemplate:(nullable NSArray<__kindof SKTemplateTag *>
*)aTemplate range:(NSRange)aRange attributeClass:(Class)aClass
NS_DESIGNATED_INITIALIZER;
@property (nonatomic, nullable, readonly) NSArray<__kindof SKTemplateTag *>
*template;
@property (nonatomic, readonly) NSRange range;
Modified: trunk/SKTextNoteEditor.h
===================================================================
--- trunk/SKTextNoteEditor.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKTextNoteEditor.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -50,7 +50,9 @@
NSUndoManager *undoManager;
}
-- (instancetype)initWithAnnotation:(PDFAnnotation *)anAnnotation
delegate:(id<SKTextNoteEditorDelegate>)aDelegate;
+- (instancetype)initWithAnnotation:(PDFAnnotation *)anAnnotation
delegate:(id<SKTextNoteEditorDelegate>)aDelegate NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithFrame:(NSRect)frameRect NS_UNAVAILABLE;
+- (instancetype)initWithCoder:(NSCoder *)coder NS_UNAVAILABLE;
@property (nonatomic, readonly) NSString *currentString;
Modified: trunk/SKThumbnail.h
===================================================================
--- trunk/SKThumbnail.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKThumbnail.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -61,7 +61,8 @@
@property (nonatomic, nullable, readonly) PDFPage *page;
@property (nonatomic, readonly, getter=isPlaceholder) BOOL placeholder;
-- (instancetype)initWithImage:(NSImage *)anImage label:(NSString *)aLabel
pageIndex:(NSUInteger)anIndex;
+- (instancetype)initWithImage:(NSImage *)anImage label:(NSString *)aLabel
pageIndex:(NSUInteger)anIndex NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
- (void)setNeedsUpdate;
Modified: trunk/SKThumbnailStamp.h
===================================================================
--- trunk/SKThumbnailStamp.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKThumbnailStamp.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -47,7 +47,8 @@
CGFloat fraction;
}
-- (instancetype)initWithImage:(NSImage *)anImage rect:(NSRect)aRect
fraction:(CGFloat)aFraction;
+- (instancetype)initWithImage:(NSImage *)anImage rect:(NSRect)aRect
fraction:(CGFloat)aFraction NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
- (void)drawForPage:(PDFPage *)pdfPage withBox:(PDFDisplayBox)box;
Modified: trunk/SKTransitionInfo.h
===================================================================
--- trunk/SKTransitionInfo.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKTransitionInfo.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -52,6 +52,7 @@
BOOL shouldRestrict;
}
+- (instancetype)init NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithTransitionInfo:(SKTransitionInfo *)info;
- (instancetype)initWithProperties:(NSDictionary *)dictionary;
Modified: trunk/SKTransitionInfo.m
===================================================================
--- trunk/SKTransitionInfo.m 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKTransitionInfo.m 2025-10-02 15:53:38 UTC (rev 15678)
@@ -118,7 +118,7 @@
}
- (instancetype)initWithTransitionInfo:(SKTransitionInfo *)info {
- self = [super init];
+ self = [self init];
if (self) {
style = [info style];
duration = [info duration];
Modified: trunk/SKTypeSelectHelper.h
===================================================================
--- trunk/SKTypeSelectHelper.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKTypeSelectHelper.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -64,7 +64,7 @@
+ (instancetype)typeSelectHelper;
+
(instancetype)typeSelectHelperWithMatchOption:(SKTypeSelectMatchOption)aMatchOption;
-- (instancetype)initWithMatchOption:(SKTypeSelectMatchOption)aMatchOption;
+- (instancetype)initWithMatchOption:(SKTypeSelectMatchOption)aMatchOption
NS_DESIGNATED_INITIALIZER;
- (void)rebuildTypeSelectSearchCache;
Modified: trunk/SKVersionNumber.h
===================================================================
--- trunk/SKVersionNumber.h 2025-10-02 14:47:52 UTC (rev 15677)
+++ trunk/SKVersionNumber.h 2025-10-02 15:53:38 UTC (rev 15678)
@@ -64,7 +64,8 @@
+ (NSComparisonResult)compareVersionString:(NSString *)versionString
toVersionString:(NSString *)otherVersionString;
-- (nullable instancetype)initWithVersionString:(NSString *)versionString;
+- (nullable instancetype)initWithVersionString:(NSString *)versionString
NS_DESIGNATED_INITIALIZER;
+- (instancetype)init NS_UNAVAILABLE;
- (NSInteger)componentAtIndex:(NSUInteger)componentIndex;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
