Revision: 15698
http://sourceforge.net/p/skim-app/code/15698
Author: hofman
Date: 2025-10-20 16:23:15 +0000 (Mon, 20 Oct 2025)
Log Message:
-----------
use class extensions instead of Private category
Modified Paths:
--------------
trunk/SKBookmarkController.m
trunk/SKConversionProgressController.m
trunk/SKDisplayPreferences.m
trunk/SKInfoWindowController.m
trunk/SKMainDocument.m
trunk/SKMainToolbarController.m
trunk/SKMainTouchBarController.m
trunk/SKMainWindowController.m
trunk/SKNoteOutlineView.m
trunk/SKNoteToolbarController.m
trunk/SKNoteTypeSheetController.m
trunk/SKNoteWindowController.m
trunk/SKPDFView.m
trunk/SKSecondaryPDFView.m
trunk/SKSnapshotPDFView.m
trunk/SKSnapshotWindow.m
trunk/SKSyncDot.m
trunk/SKTypeSelectHelper.m
Modified: trunk/SKBookmarkController.m
===================================================================
--- trunk/SKBookmarkController.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKBookmarkController.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -98,7 +98,7 @@
static inline NSLayoutConstraint *trailingConstraint(NSView *view);
-@interface SKBookmarkController (SKPrivate)
+@interface SKBookmarkController ()
- (void)setupToolbar;
- (void)saveBookmarksData;
- (void)handleApplicationWillTerminateNotification:(NSNotification
*)notification;
Modified: trunk/SKConversionProgressController.m
===================================================================
--- trunk/SKConversionProgressController.m 2025-10-16 15:39:04 UTC (rev
15697)
+++ trunk/SKConversionProgressController.m 2025-10-20 16:23:15 UTC (rev
15698)
@@ -66,7 +66,7 @@
SKConversionFailed = 1
};
-@interface SKConversionProgressController (Private)
+@interface SKConversionProgressController ()
- (NSData *)newPDFDataFromURL:(NSURL *)aURL orData:(NSData *)aData
ofType:(NSString *)aFileType error:(NSError **)outError;
- (void)conversionCompleted;
- (void)conversionStarted;
Modified: trunk/SKDisplayPreferences.m
===================================================================
--- trunk/SKDisplayPreferences.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKDisplayPreferences.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -52,7 +52,7 @@
static char SKDisplayPreferencesDefaultsObservationContext;
static char SKDisplayPreferencesColorSwatchObservationContext;
-@interface SKDisplayPreferences (Private)
+@interface SKDisplayPreferences ()
- (void)updateBackgroundColors;
@end
Modified: trunk/SKInfoWindowController.m
===================================================================
--- trunk/SKInfoWindowController.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKInfoWindowController.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -65,7 +65,7 @@
#define LABEL_COLUMN_ID @"label"
#define VALUE_COLUMN_ID @"value"
-@interface SKInfoWindowController (SKPrivate)
+@interface SKInfoWindowController ()
- (void)handleViewFrameDidChangeNotification:(NSNotification *)notification;
- (void)handleWindowDidBecomeMainNotification:(NSNotification *)notification;
- (void)handleWindowDidResignMainNotification:(NSNotification *)notification;
Modified: trunk/SKMainDocument.m
===================================================================
--- trunk/SKMainDocument.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKMainDocument.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -147,7 +147,7 @@
- (NSString *)passwordUsedForUnlocking;
@end
-@interface SKMainDocument (SKPrivate)
+@interface SKMainDocument ()
- (void)tryToUnlockDocument:(PDFDocument *)document;
Modified: trunk/SKMainToolbarController.m
===================================================================
--- trunk/SKMainToolbarController.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKMainToolbarController.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -140,7 +140,7 @@
#pragma mark -
-@interface SKMainToolbarController (SKPrivate)
+@interface SKMainToolbarController ()
- (void)handleColorSwatchFrameChangedNotification:(NSNotification
*)notification;
- (void)updateColorsMenu:(NSMenu *)menu;
- (void)updatePaneItemToolTips;
Modified: trunk/SKMainTouchBarController.m
===================================================================
--- trunk/SKMainTouchBarController.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKMainTouchBarController.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -65,7 +65,7 @@
static NSString *noteToolImageNames[] = {@"TouchBarTextNotePopover",
@"TouchBarAnchoredNotePopover", @"TouchBarCircleNotePopover",
@"TouchBarSquareNotePopover", @"TouchBarHighlightNotePopover",
@"TouchBarUnderlineNotePopover", @"TouchBarStrikeOutNotePopover",
@"TouchBarLineNotePopover", @"TouchBarInkNotePopover"};
-@interface SKMainTouchBarController (SKPrivate)
+@interface SKMainTouchBarController ()
- (void)chooseColor:(id)sender;
- (void)goToPreviousNextPage:(id)sender;
@@ -78,7 +78,6 @@
- (void)togglePresentation:(id)sender;
- (void)registerForNotifications;
-- (void)unregisterForNotifications;
- (void)handlePageChangedNotification:(NSNotification *)notification;
- (void)handleToolModeChangedNotification:(NSNotification *)notification;
- (void)handleAnnotationModeChangedNotification:(NSNotification *)notification;
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKMainWindowController.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -182,7 +182,7 @@
#pragma mark -
-@interface SKMainWindowController (SKPrivate)
+@interface SKMainWindowController ()
- (void)cleanup;
Modified: trunk/SKNoteOutlineView.m
===================================================================
--- trunk/SKNoteOutlineView.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKNoteOutlineView.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -56,7 +56,7 @@
#define RESIZE_EDGE_HEIGHT 5.0
-@interface SKNoteOutlineView (SKPrivate)
+@interface SKNoteOutlineView ()
@end
@implementation SKNoteOutlineView
Modified: trunk/SKNoteToolbarController.m
===================================================================
--- trunk/SKNoteToolbarController.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKNoteToolbarController.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -53,7 +53,7 @@
static char SKToolbarObservationContext;
-@interface SKNoteToolbarController (SKPrivate)
+@interface SKNoteToolbarController ()
- (void)updateSizeMode;
@end
Modified: trunk/SKNoteTypeSheetController.m
===================================================================
--- trunk/SKNoteTypeSheetController.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKNoteTypeSheetController.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -44,7 +44,7 @@
#define NOTETYPES_COUNT ([noteTypeMenu numberOfItems] - 3)
-@interface SKNoteTypeSheetController (Private)
+@interface SKNoteTypeSheetController ()
- (void)toggleDisplayNoteType:(id)sender;
- (void)displayAllNoteTypes:(id)sender;
- (void)selectNoteTypes:(id)sender;
Modified: trunk/SKNoteWindowController.m
===================================================================
--- trunk/SKNoteWindowController.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKNoteWindowController.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -78,7 +78,7 @@
#pragma mark -
-@interface SKNoteWindowController (SKPrivate)
+@interface SKNoteWindowController ()
+ (void)handleApplicationWillTerminate:(NSNotification *)notification;
- (void)handlePageLabelsChangedNotification:(NSNotification *)notification;
@end
Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKPDFView.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -189,12 +189,10 @@
@end
@interface SKPDFView () <SKReadingBarDelegate, SKLayerDelegate,
SKTextNoteEditorDelegate>
+
@property (strong) SKReadingBar *readingBar;
@property (strong) SKSyncDot *syncDot;
-@end
-@interface SKPDFView (Private)
-
- (void)editTextNoteWithEvent:(NSEvent *)theEvent;
- (BOOL)isEditingAnnotation:(PDFAnnotation *)annotation;
@@ -227,7 +225,6 @@
- (void)doResizeReadingBarWithEvent:(NSEvent *)theEvent;
- (void)doMarqueeZoomWithEvent:(NSEvent *)theEvent;
- (BOOL)doDragMouseWithEvent:(NSEvent *)theEvent;
-- (BOOL)doDragTextWithEvent:(NSEvent *)theEvent;
- (void)setCursorForMouse:(NSEvent *)theEvent;
- (void)showHelpMenu;
Modified: trunk/SKSecondaryPDFView.m
===================================================================
--- trunk/SKSecondaryPDFView.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKSecondaryPDFView.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -57,7 +57,7 @@
- (BOOL)writeSelectionToPasteboard:(NSPasteboard *)pboard types:(NSArray
*)types;
@end
-@interface SKSecondaryPDFView (SKPrivate)
+@interface SKSecondaryPDFView ()
- (void)reloadPagePopUpButton;
- (void)makeControls;
Modified: trunk/SKSnapshotPDFView.m
===================================================================
--- trunk/SKSnapshotPDFView.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKSnapshotPDFView.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -51,7 +51,7 @@
#import "SKPDFView.h"
-@interface SKSnapshotPDFView (SKPrivate)
+@interface SKSnapshotPDFView ()
- (void)resetAutoFitRectIfNeeded;
Modified: trunk/SKSnapshotWindow.m
===================================================================
--- trunk/SKSnapshotWindow.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKSnapshotWindow.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -40,7 +40,7 @@
#import "SKSnapshotWindowController.h"
-@interface NSWindow (SKPrivate)
+@interface NSWindow (SKPrivateDeclarations)
- (id)_updateButtonsForModeChanged;
@end
Modified: trunk/SKSyncDot.m
===================================================================
--- trunk/SKSyncDot.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKSyncDot.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -41,7 +41,7 @@
#import "NSShadow_SKExtensions.h"
-@interface SKSyncDot (SKPrivate)
+@interface SKSyncDot ()
- (void)finish;
- (void)animate;
@end
Modified: trunk/SKTypeSelectHelper.m
===================================================================
--- trunk/SKTypeSelectHelper.m 2025-10-16 15:39:04 UTC (rev 15697)
+++ trunk/SKTypeSelectHelper.m 2025-10-20 16:23:15 UTC (rev 15698)
@@ -49,7 +49,7 @@
#pragma mark -
-@interface SKTypeSelectHelper (SKPrivate)
+@interface SKTypeSelectHelper ()
- (NSTextView *)editor;
- (void)searchWithEvent:(NSEvent *)keyEvent;
- (void)repeatSearch;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
