Revision: 15796
http://sourceforge.net/p/skim-app/code/15796
Author: hofman
Date: 2025-11-12 17:58:14 +0000 (Wed, 12 Nov 2025)
Log Message:
-----------
use NSSecureCoding methods
Modified Paths:
--------------
trunk/SKColorCell.m
trunk/SKColorSwatch.m
trunk/SKFontWell.m
trunk/SKLineWell.m
trunk/SKNavigationWindow.m
trunk/SKShareMenuController.h
trunk/SKShareMenuController.m
trunk/SKStatusBar.m
Modified: trunk/SKColorCell.m
===================================================================
--- trunk/SKColorCell.m 2025-11-12 16:44:08 UTC (rev 15795)
+++ trunk/SKColorCell.m 2025-11-12 17:58:14 UTC (rev 15796)
@@ -47,7 +47,7 @@
- (instancetype)initWithCoder:(NSCoder *)decoder {
self = [super initWithCoder:decoder];
if (self) {
- color = [decoder decodeObjectForKey:@"color"];
+ color = [decoder decodeObjectOfClass:[NSColor class] forKey:@"color"];
shouldFill = [decoder decodeBoolForKey:@"shouldFill"];
}
return self;
Modified: trunk/SKColorSwatch.m
===================================================================
--- trunk/SKColorSwatch.m 2025-11-12 16:44:08 UTC (rev 15795)
+++ trunk/SKColorSwatch.m 2025-11-12 17:58:14 UTC (rev 15796)
@@ -926,7 +926,7 @@
- (instancetype)initWithCoder:(NSCoder *)decoder {
self = [super initWithCoder:decoder];
if (self) {
- color = [decoder decodeObjectForKey:COLOR_KEY];
+ color = [decoder decodeObjectOfClass:[NSColor class] forKey:COLOR_KEY];
}
return self;
}
Modified: trunk/SKFontWell.m
===================================================================
--- trunk/SKFontWell.m 2025-11-12 16:44:08 UTC (rev 15795)
+++ trunk/SKFontWell.m 2025-11-12 17:58:14 UTC (rev 15796)
@@ -107,8 +107,8 @@
[newCell setAction:[oldCell action]];
[self setCell:newCell];
}
- action = NSSelectorFromString([decoder decodeObjectForKey:ACTION_KEY]);
- target = [decoder decodeObjectForKey:TARGET_KEY];
+ action = NSSelectorFromString([decoder decodeObjectOfClass:[NSString
class] forKey:ACTION_KEY]);
+ target = [decoder decodeObjectOfClass:[NSObject class]
forKey:TARGET_KEY];
[self commonInit];
}
return self;
@@ -410,7 +410,7 @@
- (instancetype)initWithCoder:(NSCoder *)decoder {
self = [super initWithCoder:decoder];
if (self) {
- [self setTextColor:[decoder decodeObjectForKey:TEXTCOLOR_KEY]];
+ [self setTextColor:[decoder decodeObjectOfClass:[NSColor class]
forKey:TEXTCOLOR_KEY]];
[self setHasTextColor:[decoder decodeBoolForKey:HASTEXTCOLOR_KEY]];
[self commonInit];
}
Modified: trunk/SKLineWell.m
===================================================================
--- trunk/SKLineWell.m 2025-11-12 16:44:08 UTC (rev 15795)
+++ trunk/SKLineWell.m 2025-11-12 17:58:14 UTC (rev 15796)
@@ -99,7 +99,7 @@
if (self) {
lineWidth = [decoder decodeDoubleForKey:SKLineWellLineWidthKey];
style = [decoder decodeIntegerForKey:SKLineWellStyleKey];
- dashPattern = [decoder decodeObjectForKey:SKLineWellDashPatternKey];
+ dashPattern = [decoder decodeObjectOfClass:[NSArray class]
forKey:SKLineWellDashPatternKey];
startLineStyle = [decoder
decodeIntegerForKey:SKLineWellStartLineStyleKey];
endLineStyle = [decoder decodeIntegerForKey:SKLineWellEndLineStyleKey];
lwFlags.displayStyle = [decoder decodeIntegerForKey:DISPLAYSTYLE_KEY];
Modified: trunk/SKNavigationWindow.m
===================================================================
--- trunk/SKNavigationWindow.m 2025-11-12 16:44:08 UTC (rev 15795)
+++ trunk/SKNavigationWindow.m 2025-11-12 17:58:14 UTC (rev 15796)
@@ -476,7 +476,7 @@
- (instancetype)initWithCoder:(NSCoder *)decoder {
self = [super initWithCoder:decoder];
if (self) {
- stringValue = [decoder decodeObjectForKey:@"stringValue"];
+ stringValue = [decoder decodeObjectOfClass:[NSString class]
forKey:@"stringValue"];
}
return self;
}
@@ -579,10 +579,10 @@
- (instancetype)initWithCoder:(NSCoder *)decoder {
self = [super initWithCoder:decoder];
if (self) {
- toolTip = [decoder decodeObjectForKey:@"toolTip"];
- alternateToolTip = [decoder decodeObjectForKey:@"alternateToolTip"];
- path = [decoder decodeObjectForKey:@"path"];
- alternatePath = [decoder decodeObjectForKey:@"alternatePath"];
+ toolTip = [decoder decodeObjectOfClass:[NSString class]
forKey:@"toolTip"];
+ alternateToolTip = [decoder decodeObjectOfClass:[NSString class]
forKey:@"alternateToolTip"];
+ path = [decoder decodeObjectOfClass:[NSString class] forKey:@"path"];
+ alternatePath = [decoder decodeObjectOfClass:[NSString class]
forKey:@"alternatePath"];
}
return self;
}
Modified: trunk/SKShareMenuController.h
===================================================================
--- trunk/SKShareMenuController.h 2025-11-12 16:44:08 UTC (rev 15795)
+++ trunk/SKShareMenuController.h 2025-11-12 17:58:14 UTC (rev 15796)
@@ -40,7 +40,7 @@
NS_ASSUME_NONNULL_BEGIN
-@interface SKShareMenuController : NSObject <NSMenuDelegate, NSCoding> {
+@interface SKShareMenuController : NSObject <NSMenuDelegate, NSSecureCoding> {
__weak NSDocument *document;
}
Modified: trunk/SKShareMenuController.m
===================================================================
--- trunk/SKShareMenuController.m 2025-11-12 16:44:08 UTC (rev 15795)
+++ trunk/SKShareMenuController.m 2025-11-12 17:58:14 UTC (rev 15796)
@@ -53,6 +53,8 @@
- (void)encodeWithCoder:(NSCoder *)coder {}
++ (BOOL)supportsSecureCoding { return YES; }
+
- (void)menuNeedsUpdate:(NSMenu *)menu {
[menu removeAllItems];
NSDocument *doc = [self document] ?: [[NSDocumentController
sharedDocumentController] currentDocument];
Modified: trunk/SKStatusBar.m
===================================================================
--- trunk/SKStatusBar.m 2025-11-12 16:44:08 UTC (rev 15795)
+++ trunk/SKStatusBar.m 2025-11-12 17:58:14 UTC (rev 15796)
@@ -121,12 +121,12 @@
- (instancetype)initWithCoder:(NSCoder *)decoder {
self = [super initWithCoder:decoder];
if (self) {
- leftField = [decoder decodeObjectForKey:@"leftField"];
- rightField = [decoder decodeObjectForKey:@"rightField"];
- iconView = [decoder decodeObjectForKey:@"iconView"];
- progressIndicator = [decoder decodeObjectForKey:@"progressIndicator"];
- leftLeadingConstraint = [decoder
decodeObjectForKey:@"leftLeadingConstraint"];
- rightTrailingConstraint = [decoder
decodeObjectForKey:@"rightTrailingConstraint"];
+ leftField = [decoder decodeObjectOfClass:[NSTextField class]
forKey:@"leftField"];
+ rightField = [decoder decodeObjectOfClass:[NSTextField class]
forKey:@"rightField"];
+ iconView = [decoder decodeObjectOfClass:[NSImageView class]
forKey:@"iconView"];
+ progressIndicator = [decoder decodeObjectOfClass:[NSProgressIndicator
class] forKey:@"progressIndicator"];
+ leftLeadingConstraint = [decoder
decodeObjectOfClass:[NSLayoutConstraint class] forKey:@"leftLeadingConstraint"];
+ rightTrailingConstraint = [decoder
decodeObjectOfClass:[NSLayoutConstraint class]
forKey:@"rightTrailingConstraint"];
animating = NO;
}
return self;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
