Revision: 15928
          http://sourceforge.net/p/skim-app/code/15928
Author:   hofman
Date:     2025-12-26 17:39:37 +0000 (Fri, 26 Dec 2025)
Log Message:
-----------
Allow changing display direction from all display modes, changing displayMode 
if necessary

Modified Paths:
--------------
    trunk/SKMainToolbarController.m
    trunk/SKMainWindowController_Actions.m
    trunk/SKMainWindowController_UI.m

Modified: trunk/SKMainToolbarController.m
===================================================================
--- trunk/SKMainToolbarController.m     2025-12-26 17:35:41 UTC (rev 15927)
+++ trunk/SKMainToolbarController.m     2025-12-26 17:39:37 UTC (rev 15928)
@@ -1017,10 +1017,9 @@
                [identifier 
isEqualToString:SKDocumentToolbarContinuousItemIdentifier] ||
                [identifier 
isEqualToString:SKDocumentToolbarPageBreaksItemIdentifier] ||
                [identifier 
isEqualToString:SKDocumentToolbarDisplaysRTLItemIdentifier] ||
-               [identifier 
isEqualToString:SKDocumentToolbarBookModeItemIdentifier]) {
+               [identifier 
isEqualToString:SKDocumentToolbarBookModeItemIdentifier] ||
+               [identifier 
isEqualToString:SKDocumentToolbarDisplayDirectionItemIdentifier]) {
         return [mainController.pdfView.document isLocked] == NO && 
[mainController hasOverview] == NO;
-    } else if ([identifier 
isEqualToString:SKDocumentToolbarDisplayDirectionItemIdentifier]) {
-        return [mainController.pdfView.document isLocked] == NO && 
[mainController hasOverview] == NO && [mainController.pdfView displayMode] == 
kPDFDisplaySinglePageContinuous;
     } else if ([identifier 
isEqualToString:SKDocumentToolbarToolModeItemIdentifier]) {
         return [mainController hasOverview] == NO;
     } else if ([identifier 
isEqualToString:SKDocumentToolbarNewTextNoteItemIdentifier] ||
@@ -1256,6 +1255,7 @@
 - (IBAction)changeDisplayDirection:(id)sender {
     PDFDisplayDirection direction = [sender selectedTag];
     [mainController.pdfView setDisplayDirectionAndRewind:direction];
+    [mainController.pdfView setDisplayMode:kPDFDisplaySinglePageContinuous];
 }
 
 - (IBAction)changeDisplaysRTL:(id)sender {

Modified: trunk/SKMainWindowController_Actions.m
===================================================================
--- trunk/SKMainWindowController_Actions.m      2025-12-26 17:35:41 UTC (rev 
15927)
+++ trunk/SKMainWindowController_Actions.m      2025-12-26 17:39:37 UTC (rev 
15928)
@@ -310,6 +310,7 @@
 
 - (IBAction)changeDisplayDirection:(id)sender {
     [pdfView setDisplayDirectionAndRewind:[sender tag]];
+    [pdfView setDisplayMode:kPDFDisplaySinglePageContinuous];
 }
 
 - (IBAction)toggleDisplaysRTL:(id)sender {

Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m   2025-12-26 17:35:41 UTC (rev 15927)
+++ trunk/SKMainWindowController_UI.m   2025-12-26 17:39:37 UTC (rev 15928)
@@ -1817,7 +1817,7 @@
         return [self interactionMode] != SKPresentationMode && [self 
hasOverview] == NO && [[self pdfDocument] isLocked] == NO;
     } else if (action == @selector(changeDisplayDirection:)) {
         [menuItem setState:[pdfView displayDirection] == [menuItem tag] ? 
NSControlStateValueOn : NSControlStateValueOff];
-        return [self interactionMode] != SKPresentationMode && [self 
hasOverview] == NO && [[self pdfDocument] isLocked] == NO && [pdfView 
displayMode] == kPDFDisplaySinglePageContinuous;
+        return [self interactionMode] != SKPresentationMode && [self 
hasOverview] == NO && [[self pdfDocument] isLocked] == NO;
     } else if (action == @selector(toggleDisplaysRTL:)) {
         [menuItem setState:[pdfView displaysRTL] ? NSControlStateValueOn : 
NSControlStateValueOff];
         return [self interactionMode] != SKPresentationMode && [self 
hasOverview] == NO && [[self pdfDocument] isLocked] == NO;

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to