Revision: 16063
http://sourceforge.net/p/skim-app/code/16063
Author: hofman
Date: 2026-03-15 16:19:25 +0000 (Sun, 15 Mar 2026)
Log Message:
-----------
predeclare classes instead of importing Quartz in headers
Modified Paths:
--------------
trunk/SKGroupedSearchResult.h
trunk/SKGroupedSearchResult.m
trunk/SKNoteText.h
trunk/SKNoteText.m
trunk/SKNotesDocument.h
trunk/SKNotesDocument.m
trunk/SKSyncDot.h
trunk/SKSyncDot.m
trunk/SKTextNoteEditor.h
trunk/SKTextNoteEditor.m
trunk/SKThumbnailStamp.h
trunk/SKThumbnailStamp.m
Modified: trunk/SKGroupedSearchResult.h
===================================================================
--- trunk/SKGroupedSearchResult.h 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKGroupedSearchResult.h 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,7 +37,6 @@
*/
#import <Cocoa/Cocoa.h>
-#import <Quartz/Quartz.h>
NS_ASSUME_NONNULL_BEGIN
@@ -44,6 +43,8 @@
extern NSString * const SKGroupedSearchResultCountKey;
extern NSString * const SKGroupedSearchResultPageIndexKey;
+@class PDFPage, PDFSelection;
+
@interface SKGroupedSearchResult : NSObject {
PDFPage *page;
NSUInteger maxCount;
Modified: trunk/SKGroupedSearchResult.m
===================================================================
--- trunk/SKGroupedSearchResult.m 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKGroupedSearchResult.m 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,6 +37,7 @@
*/
#import "SKGroupedSearchResult.h"
+#import <Quartz/Quartz.h>
#import "PDFPage_SKExtensions.h"
#import "PDFSelection_SKExtensions.h"
#import "NSGeometry_SKExtensions.h"
Modified: trunk/SKNoteText.h
===================================================================
--- trunk/SKNoteText.h 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKNoteText.h 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,10 +37,11 @@
*/
#import <Cocoa/Cocoa.h>
-#import <Quartz/Quartz.h>
NS_ASSUME_NONNULL_BEGIN
+@class PDFPage;
+
@interface SKNoteText : NSObject {
__weak PDFAnnotation *note;
}
Modified: trunk/SKNoteText.m
===================================================================
--- trunk/SKNoteText.m 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKNoteText.m 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,6 +37,7 @@
*/
#import "SKNoteText.h"
+#import <Quartz/Quartz.h>
#import "PDFAnnotation_SKExtensions.h"
#import "NSAttributedString_SKExtensions.h"
Modified: trunk/SKNotesDocument.h
===================================================================
--- trunk/SKNotesDocument.h 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKNotesDocument.h 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,12 +37,11 @@
*/
#import <Cocoa/Cocoa.h>
-#import <Quartz/Quartz.h>
#import "SKNoteTypeSheetController.h"
NS_ASSUME_NONNULL_BEGIN
-@class SKNoteOutlineView, SKStatusBar;
+@class SKNoteOutlineView, SKStatusBar, PDFPage;
@interface SKNotesDocument : NSDocument <NSWindowDelegate, NSToolbarDelegate,
NSOutlineViewDataSource, SKNoteTypeSheetControllerDelegate> {
SKNoteOutlineView *outlineView;
Modified: trunk/SKNotesDocument.m
===================================================================
--- trunk/SKNotesDocument.m 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKNotesDocument.m 2026-03-15 16:19:25 UTC (rev 16063)
@@ -43,6 +43,7 @@
#import "NSValue_SKExtensions.h"
#import "NSURL_SKExtensions.h"
#import "SKTypeSelectHelper.h"
+#import <Quartz/Quartz.h>
#import <SkimNotes/SkimNotes.h>
#import "SKNotesPage.h"
#import "SKPDFDocument.h"
Modified: trunk/SKSyncDot.h
===================================================================
--- trunk/SKSyncDot.h 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKSyncDot.h 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,7 +37,6 @@
*/
#import <Cocoa/Cocoa.h>
-#import <Quartz/Quartz.h>
#import <stdatomic.h>
NS_ASSUME_NONNULL_BEGIN
@@ -44,6 +43,8 @@
typedef void (^SKSyncDotUpdateBlock)(BOOL finished);
+@class PDFPage;
+
@interface SKSyncDot : NSObject {
NSPoint point;
PDFPage *page;
Modified: trunk/SKSyncDot.m
===================================================================
--- trunk/SKSyncDot.m 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKSyncDot.m 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,6 +37,7 @@
*/
#import "SKSyncDot.h"
+#import <Quartz/Quartz.h>
#import "NSGeometry_SKExtensions.h"
#import "NSShadow_SKExtensions.h"
Modified: trunk/SKTextNoteEditor.h
===================================================================
--- trunk/SKTextNoteEditor.h 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKTextNoteEditor.h 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,11 +37,11 @@
*/
#import <Cocoa/Cocoa.h>
-#import <Quartz/Quartz.h>
NS_ASSUME_NONNULL_BEGIN
@protocol SKTextNoteEditorDelegate;
+@class PDFAnnotation;
@interface SKTextNoteEditor : NSView <NSTextViewDelegate> {
NSTextView *textView;
Modified: trunk/SKTextNoteEditor.m
===================================================================
--- trunk/SKTextNoteEditor.m 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKTextNoteEditor.m 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,6 +37,7 @@
*/
#import "SKTextNoteEditor.h"
+#import <Quartz/Quartz.h>
#import "PDFAnnotation_SKExtensions.h"
#import "NSEvent_SKExtensions.h"
#import "SKChainedUndoManager.h"
Modified: trunk/SKThumbnailStamp.h
===================================================================
--- trunk/SKThumbnailStamp.h 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKThumbnailStamp.h 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,10 +37,11 @@
*/
#import <Cocoa/Cocoa.h>
-#import <Quartz/Quartz.h>
NS_ASSUME_NONNULL_BEGIN
+@class PDFPage;
+
@interface SKThumbnailStamp : NSObject {
NSImage *image;
NSRect rect;
Modified: trunk/SKThumbnailStamp.m
===================================================================
--- trunk/SKThumbnailStamp.m 2026-03-14 22:04:34 UTC (rev 16062)
+++ trunk/SKThumbnailStamp.m 2026-03-15 16:19:25 UTC (rev 16063)
@@ -37,6 +37,7 @@
*/
#import "SKThumbnailStamp.h"
+#import <Quartz/Quartz.h>
@implementation SKThumbnailStamp
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
