Revision: 16079
http://sourceforge.net/p/skim-app/code/16079
Author: hofman
Date: 2026-03-19 17:14:53 +0000 (Thu, 19 Mar 2026)
Log Message:
-----------
use id rather than boolean to avoid capture of self
Modified Paths:
--------------
trunk/SKMainWindowController_FullScreen.m
Modified: trunk/SKMainWindowController_FullScreen.m
===================================================================
--- trunk/SKMainWindowController_FullScreen.m 2026-03-19 16:48:36 UTC (rev
16078)
+++ trunk/SKMainWindowController_FullScreen.m 2026-03-19 17:14:53 UTC (rev
16079)
@@ -621,14 +621,14 @@
[self displayStaticContentInWindow:displayWindow ordered:NSWindowBelow];
BOOL showToolbarWindow = [[NSUserDefaults standardUserDefaults]
boolForKey:SKAutoHideToolbarInFullScreenKey] == NO;
CGFloat offset = 0.0;
- BOOL showNoteToolbar = NO;
+ NSTitlebarAccessoryViewController *noteToolbar = nil;
CALayer *blackLayer = nil;
if (showToolbarWindow) {
if ([[window toolbar] isVisible]) {
offset = fullScreenOffset(window);
if (noteToolbarController && [noteToolbarController isHidden] ==
NO && [noteToolbarController fullScreenMinHeight] <= 0.0 && [[window
titlebarAccessoryViewControllers] containsObject:noteToolbarController]) {
- showNoteToolbar = YES;
- [noteToolbarController setHidden:YES];
+ noteToolbar = noteToolbarController;
+ [noteToolbar setHidden:YES];
}
for (NSView *view in [[[window
standardWindowButton:NSWindowCloseButton] superview] subviews]) {
if ([view isKindOfClass:[NSControl class]])
@@ -668,8 +668,7 @@
completionHandler:^{
[displayWindow orderOut:nil];
[blackLayer removeFromSuperlayer];
- if (showNoteToolbar)
- [noteToolbarController setHidden:NO];
+ [noteToolbar setHidden:NO];
}];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
