Revision: 16082
http://sourceforge.net/p/skim-app/code/16082
Author: hofman
Date: 2026-03-22 17:27:45 +0000 (Sun, 22 Mar 2026)
Log Message:
-----------
target toolbar controller for some menu items to avoid the mainController to
change the title
Modified Paths:
--------------
trunk/SKMainToolbarController.m
Modified: trunk/SKMainToolbarController.m
===================================================================
--- trunk/SKMainToolbarController.m 2026-03-20 17:33:42 UTC (rev 16081)
+++ trunk/SKMainToolbarController.m 2026-03-22 17:27:45 UTC (rev 16082)
@@ -885,7 +885,7 @@
} else if ([identifier
isEqualToString:SKDocumentToolbarContentsPaneItemIdentifier]) {
- menuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Contents Pane", @"Menu item title")
action:@selector(toggleLeftSidePane:) target:mainController];
+ menuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Contents Pane", @"Menu item title")
action:@selector(toggleLeftSidePane:) target:self];
[item setLabels:NSLocalizedString(@"Contents Pane", @"Toolbar item
label")];
[item setToolTip:[mainController leftSidePaneIsOpen] ?
NSLocalizedString(@"Hide Contents Pane", @"Tool tip message") :
NSLocalizedString(@"Show Contents Pane", @"Tool tip message")];
@@ -896,7 +896,7 @@
} else if ([identifier
isEqualToString:SKDocumentToolbarNotesPaneItemIdentifier]) {
- menuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Notes Pane", @"Menu item title")
action:@selector(toggleRightSidePane:) target:mainController];
+ menuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Notes Pane", @"Menu item title")
action:@selector(toggleRightSidePane:) target:self];
[item setLabels:NSLocalizedString(@"Notes Pane", @"Toolbar item
label")];
[item setToolTip:[mainController rightSidePaneIsOpen] ?
NSLocalizedString(@"Hide Notes Pane", @"Tool tip message") :
NSLocalizedString(@"Show Notes Pane", @"Tool tip message")];
@@ -907,7 +907,7 @@
} else if ([identifier
isEqualToString:SKDocumentToolbarSplitPDFItemIdentifier]) {
- menuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Notes Pane", @"Menu item title")
action:@selector(toggleSplitPDF:) target:mainController];
+ menuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Notes Pane", @"Menu item title")
action:@selector(toggleSplitPDF:) target:self];
[item setLabels:NSLocalizedString(@"Split PDF", @"Toolbar item
label")];
[item setToolTip:[(NSView *)mainController.secondaryPdfView
window] ? NSLocalizedString(@"Hide Split PDF", @"Tool tip message") :
NSLocalizedString(@"Show Split PDF", @"Tool tip message")];
@@ -1518,7 +1518,7 @@
- (void)handleSplitViewDidResizeSubviewsNotification:(NSNotification
*)notification {
NSSplitView *splitView = [notification object];
NSInteger isLeftSideViewCollapsed = [splitView
isSubviewCollapsed:[[splitView subviews] firstObject]];
- NSInteger isRightSideViewCollapsed = [splitView
isSubviewCollapsed:[[splitView subviews] lastObject]];
+ NSInteger isRightSideViewCollapsed = [splitView
isSubviewCollapsed:[[splitView subviews] objectAtIndex:2]];
if (isLeftSideViewCollapsed != [leftPaneButton tag]) {
[leftPaneButton setTag:isLeftSideViewCollapsed];
[self leftSidePaneDidShowOrHide];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
