Revision: 16106
http://sourceforge.net/p/skim-app/code/16106
Author: hofman
Date: 2026-03-25 22:49:30 +0000 (Wed, 25 Mar 2026)
Log Message:
-----------
determine wether to restore side pane width by wwether we savd them, no need to
separately check the preference
Modified Paths:
--------------
trunk/SKMainWindowController.m
trunk/SKMainWindowController_FullScreen.m
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2026-03-25 17:11:15 UTC (rev 16105)
+++ trunk/SKMainWindowController.m 2026-03-25 22:49:30 UTC (rev 16106)
@@ -185,8 +185,6 @@
#define SKTitleAndToolbarStyleKey @"SKTitleAndToolbarStyle"
-#define SKShowSidePanesInFullScreenKey @"SKShowSidePanesInFullScreen"
-
#pragma mark -
static SKDestination destinationFromSetup(NSDictionary *setup);
@@ -593,7 +591,7 @@
[savedNormalWindow setFrame:NSRectFromString(rectString)
display:NO];
}
- BOOL applySidePaneWidths = [self interactionMode] != SKFullScreenMode
|| [[NSUserDefaults standardUserDefaults]
boolForKey:SKShowSidePanesInFullScreenKey];
+ BOOL applySidePaneWidths = [self interactionMode] != SKFullScreenMode
|| [savedNormalSetup objectForKey:LEFTSIDEPANEWIDTH_KEY] == nil;
if (applySidePaneWidths) {
[self setLeftSideWidth:[setup objectForKey:LEFTSIDEPANEWIDTH_KEY]];
[self setRightSideWidth:[setup
objectForKey:RIGHTSIDEPANEWIDTH_KEY]];
Modified: trunk/SKMainWindowController_FullScreen.m
===================================================================
--- trunk/SKMainWindowController_FullScreen.m 2026-03-25 17:11:15 UTC (rev
16105)
+++ trunk/SKMainWindowController_FullScreen.m 2026-03-25 22:49:30 UTC (rev
16106)
@@ -573,10 +573,9 @@
NSColor *backgroundColor = [PDFView defaultBackgroundColor];
[pdfView setBackgroundColor:backgroundColor];
[secondaryPdfView setBackgroundColor:backgroundColor];
- if ([[NSUserDefaults standardUserDefaults]
boolForKey:SKShowSidePanesInFullScreenKey] == NO) {
- [self setLeftSideWidth:[savedNormalSetup
objectForKey:LEFTSIDEPANEWIDTH_KEY]];
- [self setRightSideWidth:[savedNormalSetup
objectForKey:RIGHTSIDEPANEWIDTH_KEY]];
- }
+ // this does nothing when we did not save the pane widths
+ [self setLeftSideWidth:[savedNormalSetup
objectForKey:LEFTSIDEPANEWIDTH_KEY]];
+ [self setRightSideWidth:[savedNormalSetup
objectForKey:RIGHTSIDEPANEWIDTH_KEY]];
if ([[[NSUserDefaults standardUserDefaults]
dictionaryForKey:SKDefaultFullScreenPDFDisplaySettingsKey] count])
[pdfView setDisplaySettingsAndRewind:savedNormalSetup];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
