Revision: 16124
http://sourceforge.net/p/skim-app/code/16124
Author: hofman
Date: 2026-03-28 17:08:17 +0000 (Sat, 28 Mar 2026)
Log Message:
-----------
rename action method
Modified Paths:
--------------
trunk/SKMainToolbarController.h
trunk/SKMainToolbarController.m
Modified: trunk/SKMainToolbarController.h
===================================================================
--- trunk/SKMainToolbarController.h 2026-03-28 17:05:42 UTC (rev 16123)
+++ trunk/SKMainToolbarController.h 2026-03-28 17:08:17 UTC (rev 16124)
@@ -140,7 +140,7 @@
- (IBAction)changeBookMode:(nullable id)sender;
- (IBAction)changePageBreaks:(nullable id)sender;
- (void)createNewTextNote:(nullable id)sender;
-- (void)createNewCircleNote:(nullable id)sender;
+- (void)createNewShapeNote:(nullable id)sender;
- (void)createNewMarkupNote:(nullable id)sender;
- (void)createNewLineNote:(nullable id)sender;
- (void)toggleNoteToolbar:(nullable id)sender;
Modified: trunk/SKMainToolbarController.m
===================================================================
--- trunk/SKMainToolbarController.m 2026-03-28 17:05:42 UTC (rev 16123)
+++ trunk/SKMainToolbarController.m 2026-03-28 17:08:17 UTC (rev 16124)
@@ -492,8 +492,8 @@
[self setNoteType:[[NSUserDefaults standardUserDefaults]
integerForKey:SKLastShapeNoteTypeKey] forButton:circleNoteButton];
menu = [NSMenu menu];
- [menu addItemWithTitle:NSLocalizedString(@"Circle", @"Menu item
title") imageNamed:SKImageNameToolbarAddCircleNote
action:@selector(createNewCircleNote:) target:self tag:SKNoteTypeCircle];
- [menu addItemWithTitle:NSLocalizedString(@"Box", @"Menu item
title") imageNamed:SKImageNameToolbarAddSquareNote
action:@selector(createNewCircleNote:) target:self tag:SKNoteTypeSquare];
+ [menu addItemWithTitle:NSLocalizedString(@"Circle", @"Menu item
title") imageNamed:SKImageNameToolbarAddCircleNote
action:@selector(createNewShapeNote:) target:self tag:SKNoteTypeCircle];
+ [menu addItemWithTitle:NSLocalizedString(@"Box", @"Menu item
title") imageNamed:SKImageNameToolbarAddSquareNote
action:@selector(createNewShapeNote:) target:self tag:SKNoteTypeSquare];
[circleNoteButton setMenu:menu forSegment:0];
menuItem = [[NSMenuItem alloc]
initWithSubmenuAndTitle:NSLocalizedString(@"Add Shape", @"Toolbar item label")];
@@ -1067,7 +1067,7 @@
} else if (action == @selector(createNewTextNote:)) {
[menuItem setState:[textNoteButton tagForSegment:0] == [menuItem tag]
? NSControlStateValueOn : NSControlStateValueOff];
return [mainController interactionMode] != SKPresentationMode &&
[mainController hasOverview] == NO && [mainController.pdfView.document
allowsNotes] && ([mainController.pdfView toolMode] == SKToolModeText ||
[mainController.pdfView toolMode] == SKToolModeNote) && [mainController.pdfView
hideNotes] == NO;
- } else if (action == @selector(createNewCircleNote:)) {
+ } else if (action == @selector(createNewShapeNote:)) {
[menuItem setState:[circleNoteButton tagForSegment:0] == [menuItem
tag] ? NSControlStateValueOn : NSControlStateValueOff];
return [mainController hasOverview] == NO && [mainController.pdfView
canSelectNote];
} else if (action == @selector(createNewMarkupNote:)) {
@@ -1302,7 +1302,7 @@
[self createNewNoteWithType:[sender tag] forButton:textNoteButton
defaultsKey:SKLastTextNoteTypeKey];
}
-- (void)createNewCircleNote:(id)sender {
+- (void)createNewShapeNote:(id)sender {
[self createNewNoteWithType:[sender tag] forButton:circleNoteButton
defaultsKey:SKLastShapeNoteTypeKey];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
