Revision: 16131
http://sourceforge.net/p/skim-app/code/16131
Author: hofman
Date: 2026-03-30 16:11:50 +0000 (Mon, 30 Mar 2026)
Log Message:
-----------
do not animate hidden of splitview when swapping overview
Modified Paths:
--------------
trunk/SKMainWindowController.m
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2026-03-29 16:58:11 UTC (rev 16130)
+++ trunk/SKMainWindowController.m 2026-03-30 16:11:50 UTC (rev 16131)
@@ -1705,23 +1705,24 @@
}
if (animate) {
- [NSAnimationContext runAnimationGroup:^(NSAnimationContext * context){
+ [NSAnimationContext runAnimationGroup:^(NSAnimationContext *context){
[[contentView animator] addSubview:overviewContentView];
- [[oldView animator] setHidden:YES];
[NSLayoutConstraint activateConstraints:constraints];
}
completionHandler:^{
+ [[self window] makeFirstResponder:overviewView];
+ [oldView setHidden:YES];
[overviewView scrollRectToVisible:[overviewView
frameForItemAtIndex:[[pdfView currentPage] pageIndex]]];
[[self window] recalculateKeyViewLoop];
- [touchBarController overviewChanged];
}];
} else {
- [overviewView scrollRectToVisible:[overviewView
frameForItemAtIndex:[[pdfView currentPage] pageIndex]]];
[contentView addSubview:overviewContentView];
+ [NSLayoutConstraint activateConstraints:constraints];
+ [[self window] makeFirstResponder:overviewView];
[oldView setHidden:YES];
- [NSLayoutConstraint activateConstraints:constraints];
+ [overviewView scrollRectToVisible:[overviewView
frameForItemAtIndex:[[pdfView currentPage] pageIndex]]];
+ [[self window] recalculateKeyViewLoop];
}
- [[self window] makeFirstResponder:overviewView];
if (isPresentation)
[NSCursor setHiddenUntilMouseMoves:NO];
[touchBarController overviewChanged];
@@ -1740,28 +1741,26 @@
// don't check interactionMode as this can be called from enterPresentation
BOOL isPresentation = 0 == ([[overviewContentView window] styleMask] &
NSWindowStyleMaskTitled);
- NSView *newView = isPresentation ? presentationView : [splitViewController
view];
- NSView *newKeyView = isPresentation ? presentationView : pdfView;
+ [isPresentation ? presentationView : [splitViewController view]
setHidden:NO];
+ [[self window] makeFirstResponder:isPresentation ? presentationView :
pdfView];
+
if (animate) {
[NSAnimationContext runAnimationGroup:^(NSAnimationContext *context){
[[overviewContentView animator] removeFromSuperview];
- [[newView animator] setHidden:NO];
}
completionHandler:^{
[[self window] recalculateKeyViewLoop];
[touchBarController overviewChanged];
[noteToolbarController validateButtons];
- [[newKeyView window] makeFirstResponder:newKeyView];
if (handler)
handler();
}];
} else {
[overviewContentView removeFromSuperview];
- [newView setHidden:NO];
+ [[self window] recalculateKeyViewLoop];
[touchBarController overviewChanged];
[noteToolbarController validateButtons];
- [[newKeyView window] makeFirstResponder:newKeyView];
if (handler)
handler();
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
