Revision: 16151
http://sourceforge.net/p/skim-app/code/16151
Author: hofman
Date: 2026-04-02 15:43:17 +0000 (Thu, 02 Apr 2026)
Log Message:
-----------
check superview of split pdfview rather than window, as the latter can be nil
when showing the overview
Modified Paths:
--------------
trunk/SKMainToolbarController.m
trunk/SKMainWindowController_Actions.m
trunk/SKMainWindowController_UI.m
Modified: trunk/SKMainToolbarController.m
===================================================================
--- trunk/SKMainToolbarController.m 2026-04-02 15:38:26 UTC (rev 16150)
+++ trunk/SKMainToolbarController.m 2026-04-02 15:43:17 UTC (rev 16151)
@@ -907,7 +907,7 @@
menuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Notes Pane", @"Menu item title")
action:@selector(toggleSplitPDF:) target:self];
[item setLabels:NSLocalizedString(@"Split PDF", @"Toolbar item
label")];
- [item setToolTip:[(NSView *)mainController.secondaryPdfView
window] ? NSLocalizedString(@"Hide Split PDF", @"Tool tip message") :
NSLocalizedString(@"Show Split PDF", @"Tool tip message")];
+ [item setToolTip:[(NSView *)mainController.secondaryPdfView
superview] ? NSLocalizedString(@"Hide Split PDF", @"Tool tip message") :
NSLocalizedString(@"Show Split PDF", @"Tool tip message")];
[item setView:splitPDFButton];
[item setMenuFormRepresentation:menuItem];
Modified: trunk/SKMainWindowController_Actions.m
===================================================================
--- trunk/SKMainWindowController_Actions.m 2026-04-02 15:38:26 UTC (rev
16150)
+++ trunk/SKMainWindowController_Actions.m 2026-04-02 15:43:17 UTC (rev
16151)
@@ -1073,7 +1073,7 @@
if (mwcFlags.isAnimatingSplitPDF)
return;
- if ([secondaryPdfView window]) {
+ if ([secondaryPdfView superview]) {
NSSplitViewItem *item = [[pdfSplitViewController splitViewItems]
lastObject];
Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m 2026-04-02 15:38:26 UTC (rev 16150)
+++ trunk/SKMainWindowController_UI.m 2026-04-02 15:43:17 UTC (rev 16151)
@@ -1599,7 +1599,7 @@
- (BOOL)PDFView:(PDFView *)aPDFView performAction:(PDFAction *)action {
if ([action isKindOfClass:[PDFActionGoTo class]] && ([NSEvent
modifierFlags] & NSEventModifierFlagDeviceIndependentFlagsMask) ==
NSEventModifierFlagShift) {
BOOL animating = NO;
- if ([secondaryPdfView window] == nil) {
+ if ([secondaryPdfView superview] == nil) {
animating = [NSView shouldShowSlideAnimation];
[self toggleSplitPDF:nil];
}
@@ -1791,7 +1791,7 @@
[menuItem setTitle:NSLocalizedString(@"Show Overview", @"Menu item
title")];
return YES;
} else if (action == @selector(toggleSplitPDF:)) {
- if ([(NSView *)secondaryPdfView window])
+ if ([(NSView *)secondaryPdfView superview])
[menuItem setTitle:NSLocalizedString(@"Hide Split PDF", @"Menu
item title")];
else
[menuItem setTitle:NSLocalizedString(@"Show Split PDF", @"Menu
item title")];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
