Revision: 16203
http://sourceforge.net/p/skim-app/code/16203
Author: hofman
Date: 2026-05-02 23:07:58 +0000 (Sat, 02 May 2026)
Log Message:
-----------
don't need MIN, MAX as we already compare
Modified Paths:
--------------
trunk/PDFSelection_SKExtensions.m
trunk/SKMainWindowController_UI.m
Modified: trunk/PDFSelection_SKExtensions.m
===================================================================
--- trunk/PDFSelection_SKExtensions.m 2026-05-02 18:11:39 UTC (rev 16202)
+++ trunk/PDFSelection_SKExtensions.m 2026-05-02 23:07:58 UTC (rev 16203)
@@ -133,22 +133,24 @@
NSUInteger length = [pageString length];
NSUInteger i = [self safeIndexOfFirstCharacterOnPage:page];
NSUInteger j = [self safeIndexOfLastCharacterOnPage:page];
- NSUInteger start = MAX(i, 15) - 15;
- NSUInteger end = MIN(j + 55, length);
+ NSUInteger start = 0;
+ NSUInteger end = length;
// Extend selection, try to break at space
- if (start > 0) {
- NSUInteger k = NSMaxRange([pageString
rangeOfCharacterFromSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]
options:0 range:NSMakeRange(start, i - start)]);
+ if (i > 15) {
+ NSUInteger k = NSMaxRange([pageString
rangeOfCharacterFromSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]
options:0 range:NSMakeRange(i - 15, 15)]);
if (k == NSNotFound)
- start = MAX(i, 10) - 10;
+ start = i - 10;
else if (k + 5 <= i)
start = k;
+ else
+ start = i - 15;
}
- if (end < length) {
- NSUInteger k = [pageString rangeOfCharacterFromSet:[NSCharacterSet
whitespaceAndNewlineCharacterSet] options:NSBackwardsSearch
range:NSMakeRange(MAX(j, end - 10), end - MAX(j, end - 10))].location;
+ if (j + 55 < length) {
+ NSUInteger k = [pageString rangeOfCharacterFromSet:[NSCharacterSet
whitespaceAndNewlineCharacterSet] options:NSBackwardsSearch range:NSMakeRange(j
+ 40, 15)].location;
if (k == NSNotFound)
- end = MIN(j + 50, length);
- else if (j + 10 < k)
+ end = j + 50;
+ else
end = k;
}
extendedSelection = [page selectionForRange:NSMakeRange(start, end -
start)];
Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m 2026-05-02 18:11:39 UTC (rev 16202)
+++ trunk/SKMainWindowController_UI.m 2026-05-02 23:07:58 UTC (rev 16203)
@@ -2018,6 +2018,7 @@
- (void)handleNoteViewFrameDidChangeNotification:(NSNotification
*)notification {
if (mwcFlags.autoResizeNoteRows) {
+ [self performSelectorOnce:@selector(resetNoteRowHeights)
afterDelay:0.0];
[rightSideController.noteOutlineView resetRowHeights];
[rightSideController.noteOutlineView
noteHeightOfRowsChangedAnimating:NO];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
