Revision: 16271
http://sourceforge.net/p/skim-app/code/16271
Author: hofman
Date: 2026-05-10 16:30:43 +0000 (Sun, 10 May 2026)
Log Message:
-----------
remove updatingNoteSelection flag as it is never checked for
Modified Paths:
--------------
trunk/SKMainWindowController.h
trunk/SKMainWindowController.m
trunk/SKMainWindowController_UI.m
Modified: trunk/SKMainWindowController.h
===================================================================
--- trunk/SKMainWindowController.h 2026-05-10 16:02:59 UTC (rev 16270)
+++ trunk/SKMainWindowController.h 2026-05-10 16:30:43 UTC (rev 16271)
@@ -179,7 +179,6 @@
unsigned int addOrRemoveNotesInBulk:1;
unsigned int updatingOutlineSelection:1;
unsigned int updatingThumbnailSelection:1;
- unsigned int updatingNoteSelection:1;
unsigned int updatingFindResults:1;
unsigned int updatingColor:1;
unsigned int updatingFont:1;
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2026-05-10 16:02:59 UTC (rev 16270)
+++ trunk/SKMainWindowController.m 2026-05-10 16:30:43 UTC (rev 16271)
@@ -2258,9 +2258,7 @@
if ([annotation isSkimNote]) {
[annotation setShouldDisplay:[pdfView hideNotes] == NO];
[annotation setShouldPrint:[pdfView hideNotes] == NO];
- mwcFlags.updatingNoteSelection = 1;
[self insertObject:annotation inNotesAtIndex:[notes count]];
- mwcFlags.updatingNoteSelection = 0;
[rightSideController.noteOutlineView reloadData];
}
@@ -2301,11 +2299,9 @@
if ([[self selectedNotes] containsObject:annotation])
[rightSideController.noteOutlineView deselectAll:self];
- mwcFlags.updatingNoteSelection = 1;
NSUInteger i = [notes indexOfObject:annotation];
if (i != NSNotFound)
[self removeObjectFromNotesAtIndex:i];
- mwcFlags.updatingNoteSelection = 0;
[rightSideController.noteOutlineView reloadData];
}
Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m 2026-05-10 16:02:59 UTC (rev 16270)
+++ trunk/SKMainWindowController_UI.m 2026-05-10 16:30:43 UTC (rev 16271)
@@ -468,11 +468,9 @@
}
}];
if (selAnnotation) {
- mwcFlags.updatingNoteSelection = 1;
NSInteger row = [rightSideController.noteOutlineView
rowForItem:selAnnotation];
[rightSideController.noteOutlineView selectRowIndexes:[NSIndexSet
indexSetWithIndex:row] byExtendingSelection:NO];
[rightSideController.noteOutlineView scrollRowToVisible:row];
- mwcFlags.updatingNoteSelection = 0;
}
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
