[Skim-app-commit] SF.net SVN: skim-app:[16283] trunk/SKMainDocument.m

[hofman--- via Skim-app-commit]

Revision: 16283
          http://sourceforge.net/p/skim-app/code/16283
Author:   hofman
Date:     2026-05-11 15:09:15 +0000 (Mon, 11 May 2026)
Log Message:
-----------
avoid initializer with nil argument

Modified Paths:
--------------
    trunk/SKMainDocument.m

Modified: trunk/SKMainDocument.m
===================================================================
--- trunk/SKMainDocument.m      2026-05-11 14:48:30 UTC (rev 16282)
+++ trunk/SKMainDocument.m      2026-05-11 15:09:15 UTC (rev 16283)
@@ -1639,14 +1639,16 @@
 
 - (void)setPresentationOptions:(NSDictionary *)dictionary {
     SKTransitionController *transitions = [[self primaryWindowController] 
transitionControllerCreating:dictionary != nil];
-    if (dictionary == nil) {
+    if (dictionary) {
+        [transitions setTransition:[[SKTransitionInfo alloc] 
initWithProperties:dictionary]];
+        [transitions setPageTransitions:[dictionary 
objectForKey:PAGETRANSITIONS_KEY]];
+    } else if (transitions) {
         NSUInteger count = [[transitions pageTransitions] count];
-        if (count == 0 || count + 1 == [[self pdfDocument] pageCount])
-            return;
+        if (count > 0 && count + 1 != [[self pdfDocument] pageCount]) {
+            [transitions setTransition:[[SKTransitionInfo alloc] init]];
+            [transitions setPageTransitions:nil];
+        }
     }
-    SKTransitionInfo *transition = [[SKTransitionInfo alloc] 
initWithProperties:dictionary];
-    [transitions setTransition:transition];
-    [transitions setPageTransitions:[dictionary 
objectForKey:PAGETRANSITIONS_KEY]];
 }
 
 - (NSArray *)snapshots {

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit