Revision: 16342
http://sourceforge.net/p/skim-app/code/16342
Author: hofman
Date: 2026-06-01 16:54:18 +0000 (Mon, 01 Jun 2026)
Log Message:
-----------
page will now never be nil
Modified Paths:
--------------
trunk/PDFAnnotation_SKExtensions.h
trunk/PDFAnnotation_SKExtensions.m
Modified: trunk/PDFAnnotation_SKExtensions.h
===================================================================
--- trunk/PDFAnnotation_SKExtensions.h 2026-06-01 16:51:27 UTC (rev 16341)
+++ trunk/PDFAnnotation_SKExtensions.h 2026-06-01 16:54:18 UTC (rev 16342)
@@ -63,7 +63,7 @@
+ (nullable PDFAnnotation *)newSkimNoteWithPaths:(NSArray<NSBezierPath *>
*)paths;
-+ (nullable PDFAnnotation *)newSkimNoteWithSelection:(PDFSelection *)selection
forPage:(nullable PDFPage *)page forType:(NSString *)type;
++ (nullable PDFAnnotation *)newSkimNoteWithSelection:(PDFSelection *)selection
forPage:(PDFPage *)page forType:(NSString *)type;
+ (NSDictionary<NSString *, id>
*)normalizedSkimNoteProperties:(NSDictionary<NSString *, id> *)properties;
Modified: trunk/PDFAnnotation_SKExtensions.m
===================================================================
--- trunk/PDFAnnotation_SKExtensions.m 2026-06-01 16:51:27 UTC (rev 16341)
+++ trunk/PDFAnnotation_SKExtensions.m 2026-06-01 16:54:18 UTC (rev 16342)
@@ -145,11 +145,6 @@
}
+ (PDFAnnotation *)newSkimNoteWithSelection:(PDFSelection *)selection
forPage:(PDFPage *)page forType:(NSString *)type {
- if (page == nil) {
- page = [selection safeFirstPage];
- if (page == nil)
- return nil;
- }
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
return [[PDFAnnotationMarkup alloc] initSkimNoteWithSelection:selection
forPage:page forType:type];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
