Revision: 16420
http://sourceforge.net/p/skim-app/code/16420
Author: hofman
Date: 2026-09-05 17:47:42 +0000 (Sat, 05 Sep 2026)
Log Message:
-----------
add filters to array instead of returning
Modified Paths:
--------------
trunk/NSGraphics_SKExtensions.m
Modified: trunk/NSGraphics_SKExtensions.m
===================================================================
--- trunk/NSGraphics_SKExtensions.m 2026-09-05 17:43:00 UTC (rev 16419)
+++ trunk/NSGraphics_SKExtensions.m 2026-09-05 17:47:42 UTC (rev 16420)
@@ -198,8 +198,7 @@
return backgroundWhite >= 0.0 ? backgroundWhite : [[NSWorkspace
sharedWorkspace] accessibilityDisplayShouldIncreaseContrast] ? 0.0662 : 0.0900;
}
-static NSArray *colorInvertFilters(CGFloat b, CGFloat w) {
- NSMutableArray *filters = [NSMutableArray array];
+static inline void addColorInvertFilters(NSMutableArray *filters, CGFloat b,
CGFloat w) {
CIFilter *filter;
CGFloat f = 1.0 + b - w;
CGFloat lrf = LR * f, lgf = LG * f, lbf = LB * f;
@@ -212,7 +211,6 @@
[filters addObject:filter];
if ((filter = [CIFilter filterWithName:@"CIGammaAdjust"
keysAndValues:@"inputPower", @1.6, nil]))
[filters addObject:filter];
- return filters;
}
NSArray *SKColorEffectFilters(void) {
@@ -230,16 +228,17 @@
[filters addObject:filter];
}
if (SKHasDarkAppearance() && [sud boolForKey:SKInvertColorsInDarkModeKey])
{
- [filters addObjectsFromArray:colorInvertFilters(1.0,
invertedColorsBackgroundWhite())];
+ addColorInvertFilters(filters, 1.0, invertedColorsBackgroundWhite());
}
return filters;
}
NSArray *SKInvertedColorEffectFilters(void) {
+ NSMutableArray *filters = [NSMutableArray array];
if (SKHasDarkAppearance() && [[NSUserDefaults standardUserDefaults]
boolForKey:SKInvertColorsInDarkModeKey]) {
// this is roughly the inverse of the color inversion filter above
// return colorInvertFilters(1.0/fmax(0.0001,
invertedColorsBackgroundWhite()), 0.0);
- return colorInvertFilters(1.0, 0.0);
+ addColorInvertFilters(filters, 1.0, 0.0);
}
- return @[];
+ return filters;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
