Revision: 16544
http://sourceforge.net/p/skim-app/code/16544
Author: hofman
Date: 2026-09-27 13:53:40 +0000 (Sun, 27 Sep 2026)
Log Message:
-----------
rename class factory method
Modified Paths:
--------------
trunk/PDFAnnotation_SKExtensions.h
trunk/PDFAnnotation_SKExtensions.m
trunk/PDFPage_SKExtensions.m
trunk/SKPDFView.m
Modified: trunk/PDFAnnotation_SKExtensions.h
===================================================================
--- trunk/PDFAnnotation_SKExtensions.h 2026-09-27 13:48:29 UTC (rev 16543)
+++ trunk/PDFAnnotation_SKExtensions.h 2026-09-27 13:53:40 UTC (rev 16544)
@@ -73,7 +73,7 @@
+ (nullable PDFAnnotation *)newSkimNoteWithPaths:(NSArray<NSBezierPath *>
*)paths;
-+ (nullable PDFAnnotation *)newSkimNoteWithSelection:(PDFSelection *)selection
forPage:(PDFPage *)page forType:(NSString *)type;
++ (nullable PDFAnnotation *)newSkimNoteWithSelection:(PDFSelection *)selection
onPage:(PDFPage *)page forType:(NSString *)type;
+ (NSDictionary<NSString *, id>
*)normalizedSkimNoteProperties:(NSDictionary<NSString *, id> *)properties;
Modified: trunk/PDFAnnotation_SKExtensions.m
===================================================================
--- trunk/PDFAnnotation_SKExtensions.m 2026-09-27 13:48:29 UTC (rev 16543)
+++ trunk/PDFAnnotation_SKExtensions.m 2026-09-27 13:53:40 UTC (rev 16544)
@@ -254,7 +254,7 @@
return annotation;
}
-+ (PDFAnnotation *)newSkimNoteWithSelection:(PDFSelection *)selection
forPage:(PDFPage *)page forType:(NSString *)type {
++ (PDFAnnotation *)newSkimNoteWithSelection:(PDFSelection *)selection
onPage:(PDFPage *)page forType:(NSString *)type {
NSRect bounds = NSZeroRect;
NSPointerArray *lines = nil;
if ([selection safeIndexOfFirstCharacterOnPage:page] != NSNotFound) {
Modified: trunk/PDFPage_SKExtensions.m
===================================================================
--- trunk/PDFPage_SKExtensions.m 2026-09-27 13:48:29 UTC (rev 16543)
+++ trunk/PDFPage_SKExtensions.m 2026-09-27 13:53:40 UTC (rev 16544)
@@ -713,7 +713,7 @@
[[NSScriptCommand currentCommand]
setScriptErrorNumber:NSRequiredArgumentsMissingScriptError];
[[NSScriptCommand currentCommand] setScriptErrorString:@"New
markup notes need a selection."];
} else if (selection) {
- annotation = [PDFAnnotation newSkimNoteWithSelection:selection
forPage:self forType:type];
+ annotation = [PDFAnnotation newSkimNoteWithSelection:selection
onPage:self forType:type];
if ([props
objectForKey:SKPDFAnnotationScriptingTextContentsKey] == nil &&
[[NSUserDefaults standardUserDefaults]
integerForKey:SKDisableUpdateContentsFromEnclosedTextKey] != 2)
[props setValue:[selection cleanedString]
forKey:SKPDFAnnotationScriptingTextContentsKey];
Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m 2026-09-27 13:48:29 UTC (rev 16543)
+++ trunk/SKPDFView.m 2026-09-27 13:53:40 UTC (rev 16544)
@@ -2372,7 +2372,7 @@
string = string2;
}
- newAnnotation = [PDFAnnotation newSkimNoteWithSelection:sel
forPage:page forType:type];
+ newAnnotation = [PDFAnnotation newSkimNoteWithSelection:sel
onPage:page forType:type];
if ([string length] > 0)
[newAnnotation setString:string];
} else if ([currentAnnotation isInk]) {
@@ -2436,7 +2436,7 @@
NSString *text = disableUpdateString < 2 ? [selection cleanedString] : nil;
NSMutableArray *newAnnotations = [NSMutableArray array];
for (PDFPage *aPage in [selection pages]) {
- PDFAnnotation *newAnnotation = [PDFAnnotation
newSkimNoteWithSelection:selection forPage:aPage forType:type];
+ PDFAnnotation *newAnnotation = [PDFAnnotation
newSkimNoteWithSelection:selection onPage:aPage forType:type];
if (newAnnotation) {
if (text)
[newAnnotation setString:text];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
