Revision: 16711
http://sourceforge.net/p/skim-app/code/16711
Author: hofman
Date: 2026-10-25 22:33:09 +0000 (Sun, 25 Oct 2026)
Log Message:
-----------
don't update bookmark data when requesting fileURL without UI
Modified Paths:
--------------
trunk/SKAlias.m
trunk/SKMainWindowController_FullScreen.m
Modified: trunk/SKAlias.m
===================================================================
--- trunk/SKAlias.m 2026-10-24 22:48:14 UTC (rev 16710)
+++ trunk/SKAlias.m 2026-10-25 22:33:09 UTC (rev 16711)
@@ -143,7 +143,7 @@
shouldUpdate = YES;
} else if (data) {
NSURLBookmarkResolutionOptions options = allowUI ? 0 :
NSURLBookmarkResolutionWithoutUI | NSURLBookmarkResolutionWithoutMounting;
- fileURL = [NSURL URLByResolvingBookmarkData:data options:options
relativeToURL:nil bookmarkDataIsStale:&shouldUpdate error:NULL];
+ fileURL = [NSURL URLByResolvingBookmarkData:data options:options
relativeToURL:nil bookmarkDataIsStale:allowUI ? &shouldUpdate : NULL
error:NULL];
}
if (shouldUpdate && fileURL) {
NSData *bmData = [fileURL bookmarkDataWithOptions:0
includingResourceValuesForKeys:nil relativeToURL:nil error:NULL];
Modified: trunk/SKMainWindowController_FullScreen.m
===================================================================
--- trunk/SKMainWindowController_FullScreen.m 2026-10-24 22:48:14 UTC (rev
16710)
+++ trunk/SKMainWindowController_FullScreen.m 2026-10-25 22:33:09 UTC (rev
16711)
@@ -197,7 +197,7 @@
[preview setDelegate:self];
- [preview setPdfDocument:[pdfView document] previewPageNumber:pageIndex
displayOnScreen:screen];
+ [preview setPdfDocument:pdfDoc previewPageNumber:pageIndex
displayOnScreen:screen];
[[self document] addWindowController:preview];
} else {
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
