On 9/7/07, Christiaan Hofman <[EMAIL PROTECTED]> wrote:
>
>
> On 7 Sep 2007, at 8:41 PM, Michael McCracken wrote:
>
> >
> > On Sep 7, 2007, at 11:28 AM, Christiaan Hofman wrote:
> >
> >>
> >> On 7 Sep 2007, at 6:29 PM, Michael McCracken wrote:
> >>
> >>> I don't understand the purpose of this preference - it doesn't seem
> >>> to be settable by the UI,
> >>> is apparently on by default and I don't think that what it does
> >>> makes
> >>> sense.
> >>>
> >>
> >> It removes the download item from the download window when the
> >> download finished successfully. If it not set, the item remains in
> >> the table. What doesn't make sense?
> >
> > Mainly the code in SKDownload cleanupDownload:
> >
> > - (void)cleanupDownload {
> > [self cancelDownload];
> > if (filePath)
> > [[NSFileManager defaultManager] removeFileAtPath:[filePath
> > stringByDeletingLastPathComponent] handler:nil];
> > }
> >
> > I didn't understand why it was deleting the file.
> > Reading the rest of your reply, now I understand.
> >
> >
> >>> The way I see it, there are two choices for how this feature
> >>> ought to
> >>> work:
> >>> 1. Like a browser: it assumes you want to keep the file, so it saves
> >>> it somewhere you know about and then just opens it as a regular
> >>> file.
> >>>
> >>
> >> Then you need to popup a save panel. That would be a regression, as
> >> you don't have the choice to discard the document. Moreover I think
> >> it's annoying to show the save panel immediately, before seeing the
> >> document. Note that usually in a browser you have a particular
> >> action, either to save to the default location, or to save to a user-
> >> specified location. Here there is no such thing, as there is no
> >> action involved.
> >
> > What is wrong with saving to a default location?
> > You don't need a save panel, just use the default downloads folder.
> >
>
> That's also a possibility, but it may not be obvious to users. For
> instance, the default download location is determined by Safari, but
> not everyone uses Safari. Also I'm thinking of the situation where a
> user wants to just view a remote file. If it is the wrong file, or
> for some other reason the suer doesn't want to keep the file, he may
> think that closing the document will clean it up, which it then doesn't.
>
> >>> 2. Or: it assumes you don't want to keep the file, downloads it to /
> >>> tmp, and sets the dirty bit so you know you have to save it
> >>> somewhere
> >>> to keep it. It should also have the proxy icon so you can drag it to
> >>> the finder.
> >>>
> >>
> >> One problem is that Apple doesn't have a temporary-file setting (see
> >> the NSWorkspace docs). So the file won't be cleaned. Also, if there
> >> is an underlying file in the tmp directory, the user can just Save
> >> and think it's now saved in some default location.
> >
> > Right, so I think the clearest way to do it is as above, save to a
> > default location, not in /tmp/,
> > and just add a toolbar button & menu item to move the current file to
> > the trash so you can discard it.
> >
>
> I don't like adding a toolbar button, it would also be against the
> HIG. Also note that it is just an ordinary file.
>
> > The downloads window looks like a browser, people are used to
> > browsers, and this could work the same and be very understandable.
> >
> > -mike
> >
>
> But as I said, a browser usually initiates it with an action that
> gives you a save panel. That's not natural here.
>
> Christiaan
>
>
I've moved it to the default download location and don't remove the file. I
also changed the default value
for this pref. And I added a contextual menu to the download window to
open/reveal/move to trash.
Christiaan
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
skim-app-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-develop
