1) Done in next submission. 2) Done in next submission. --Larry
On Sat, Nov 30, 2013 at 12:15 PM, King Beowulf <kingbeow...@gmail.com>wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I've tested calbire-1.13.0 with the current SBo slackbuild script and > everything appears A-OK. Recommendations: > > 1. This line does not seems to be needed as the version string appears > to be correct: > # Make sure version string is correct. > sed -i "/^numeric_version/s|(.*)|(${VERSION//\./, })|" > src/calibre/constants.py > > It doesn't hurt anything, but sends my minimalist sensibilities all > a-flutter... > > 2. For "$PRGNAM-gui.desktop" (ie calibre-gui.desktop) I suggest we > capitalize the menu file name: > > Name=calibre > > to > > Name=Calibre > > Some DE menus will then sort the name name "correctly." For example, > Xfce sorts capitals before lower case letters (If anyone knows how to > change that I am "all ears"). > > - -Ed > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > > iEYEARECAAYFAlKaR08ACgkQXvwMaW61dLevFQCfZW+xPKJgeYBx58CZUcO9rZ8n > eTwAmQE0d7re6sR9s7AoCNf7/NI3ayAy > =wPOe > -----END PGP SIGNATURE----- > _______________________________________________ > SlackBuilds-users mailing list > SlackBuilds-users@slackbuilds.org > http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users > Archives - http://lists.slackbuilds.org/pipermail/slackbuilds-users/ > FAQ - http://slackbuilds.org/faq/ > >
_______________________________________________ SlackBuilds-users mailing list SlackBuilds-users@slackbuilds.org http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users Archives - http://lists.slackbuilds.org/pipermail/slackbuilds-users/ FAQ - http://slackbuilds.org/faq/