Philippe Bossut (Merov Linden) wrote: > Hi Robin, > > I reviewed the patch and commented in the JIRA. The skinny: I think > you're right, there's definitely something fishy there as the > doWrite() on the worker does take care of writing the header. There is > actually another piece of code in the doWrite() that is also weird as > I mentioned in the JIRA. Looking at it, that's a classic case of > unclear separation of concerns between a collection of objects. (/me > chanting "unit test! unit test!")
As i mentioed on the JIRA comment, i did most testing on 1.22.11 which does not have the 2nd code that you found, so thats an additional problem that has very recently been introduced. As for the unit tests, they don't appear to be in a great shape for outside of LL builds currently. Although you have a couple working the majority in test are not even included in the (exported) CMake rules and they seem to require quite a bit of TLC to build, I've given up for the moment. But will have to play a lot more. > > In any case, I'll check Monday first thing on my office's machine > (better dev environment than I have at home...) and we'll get to the > bottom of this. Thanks Robin
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/SLDev Please read the policies before posting to keep unmoderated posting privileges
