https://github.com/mattbishop/slf4j/commit/b1a5d650f4f78a0a2181c7883456fcf8054b623e?w=1 works for me, please merge it into upstream.
But a question? Is a bundle version good thing to have in name of logger? It prolongs logger name and usually you have right one version of a bundle at the time.... -- Hezky den / Have a nice day Libor JELÍNEK VIRTAGE SOFTWARE // software - design - web Lucni 542 // 285 04 Uhlirske Janovice // Czech Republic support: +420 315 555 488 // cell: +420 777 205 142 email/jabber: [email protected] // web: www.virtage.com Visit our developer adventures at http://devblog.virtage.com! On Fri, Sep 28, 2012 at 8:23 PM, Matthew Bishop <[email protected]> wrote: > Libor, > > I have checked in a commit to my fork that fixes this (plus formats the > project code according to slf4j spec): > > https://github.com/mattbishop/slf4j/commit/b1a5d650f4f78a0a2181c7883456fcf8 > 054b623e > > > > If this works for you, I will push it to qos.ch. > > > On 2012-09-28 4:23 AM, "Libor Jelinek" <[email protected]> wrote: > >>Hi (Matt)! >>Assume bundle having this in MANIFEST.MF: >> Bundle-SymbolicName: org.eclipse.ui.workbench; singleton:=true >> >>Then in result of >> String name = (String) >>bundle.getHeaders().get(Constants.BUNDLE_SYMBOLICNAME); >> >>in Equinox 3.7 (Indigo) is incorrect string >> "org.eclipse.ui.workbench; singleton:=true" >> >>Result of >> bundle.getSymbolicName(); >> >>is this time correct: >> "org.eclipse.ui.workbench" >> >>Please, do you have same results as me in e.g. Felix (or whatever you >>use)? If so, I fill fix constructor from >> public LogServiceImpl(Bundle bundle) { >> String name = (String) bundle.getHeaders().get( >> Constants.BUNDLE_SYMBOLICNAME); >> String version = (String) bundle.getHeaders().get( >> Constants.BUNDLE_VERSION); >> delegate = LoggerFactory.getLogger(name + '.' + version); >> } >> >>to >> public LogServiceImpl(Bundle bundle) { >> String name = bundle.getSymbolicName(); >> String version = bundle.getVersion(); >> delegate = LoggerFactory.getLogger(name + '.' + version); >> } >> >>Thanks >>Libor >> > > > Matthew Bishop, Senior Architect > Phone: 604.408.8078 ext. 101 > Email: [email protected] > > Elastic Path Software, Inc. > Web: www.elasticpath.com > Blog: www.getelastic.com > Community: grep.elasticpath.com > Careers: www.elasticpath.com/jobs > > Confidentiality Notice: This message is intended only for the use of the > designated addressee(s), and may contain information that is privileged, > confidential and exempt from disclosure. Any unauthorized viewing, > disclosure, copying, distribution or use of information contained in this > e-mail is prohibited and may be unlawful. If you received this e-mail in > error, please reply to the sender immediately to inform us you are not the > intended recipient and delete the email from your computer system. Thank you. > > _______________________________________________ >>slf4j-dev mailing list >>[email protected] >>http://mailman.qos.ch/mailman/listinfo/slf4j-dev >> > > > _______________________________________________ > slf4j-dev mailing list > [email protected] > http://mailman.qos.ch/mailman/listinfo/slf4j-dev _______________________________________________ slf4j-dev mailing list [email protected] http://mailman.qos.ch/mailman/listinfo/slf4j-dev
