SLF4J / SLF4J-577 [Open] Restore full binary compatibility and add baseline-tooling to enforce it in the future
============================== Here's what changed in this issue in the last few minutes. This issue has been created This issue is now assigned to you. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-577 ============================== Issue created ------------------------------ Hannes Wellmann created this issue on 14/Dec/22 11:26 PM Summary: Restore full binary compatibility and add baseline-tooling to enforce it in the future Issue Type: Improvement Affects Versions: 2.0.5 Assignee: SLF4J developers list Components: Core API Created: 14/Dec/22 11:26 PM Priority: Major Reporter: Hannes Wellmann Description: The documentation claims that SLF4-2 is binary compatible to slf4j-1, from a client perspective: * [https://www.slf4j.org/faq.html#compatibility] * [https://www.slf4j.org/faq.html#changesInVersion200] But for example [LoggingEvent.getMarker() in slf4j-1.7|https://github.com/qos-ch/slf4j/blob/e9ee55cca93c2bf26f14482a9bdf961c750d2a56/slf4j-api/src/main/java/org/slf4j/event/LoggingEvent.java#L14] was changed to [LoggingEvent.getMarkers() in slf4j-2|https://github.com/qos-ch/slf4j/blob/f85104040ce44ac545e15e4f41ef771a7a7f7add/slf4j-api/src/main/java/org/slf4j/event/LoggingEvent.java#L26] and now returns a List of Markers instead of a single Marker. This looks like a binary incompatible change to me. Would it be possible to restore the old {{getMarker()}} method as deprecated, in order to restore the binary compatibility? If you are interested, to avoid such changes in the future the [bnd-baseline-maven-plugin could help to avoid such change. |https://github.com/bndtools/bnd/tree/master/maven-plugins/bnd-baseline-maven-plugin]But I would have to find out first, if it is possible to perform the check like if the major version was not increment and thus removals are forbidden. Maybe this will also find other binary incompatible changes. ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59) _______________________________________________ slf4j-dev mailing list [email protected] https://mailman.qos.ch/cgi-bin/mailman/listinfo/slf4j-dev
