Hello all, I redesigned this ruleset, and now it can work as a FindBugs plugin (target to parse is changed from Java source to .class file). So it can count placeholders correctly.
https://github.com/eller86/findbugs-slf4j Check it if it is interesting for you. Thanks! On Sun, Aug 19, 2012 at 10:06 PM, Kengo TODA <[email protected]> wrote: > Thanks, I misunderstood. > I changed that XML so it will be included from next version (0.4). > > On Sun, Aug 19, 2012 at 4:17 PM, niels <[email protected]> wrote: >> That's sounds great to me, specially >> https://github.com/eller86/ruleset-for-SLF4J#number-of-placeholder-should-be-equal-to-number-of-argument. >> How ever if I understand the FAQ >> http://www.slf4j.org/faq.html#declared_static right there is no >> recommendation any more. But I guess it's easy to change the check by >> the configuration. >> >> Niels >> >> 2012/8/10 Kengo TODA <[email protected]>: >>> Hello all SLF4J users. >>> >>> I have created a simple PMD ruleset for SLF4J. It helps to unify coding >>> style >>> and fix bug. >>> >>> - https://github.com/eller86/ruleset-for-SLF4J >>> >>> I created it for myself, but I guess it would be helpful for some of you. >>> I'm happy if it works well for you. >>> >>> >>> Thanks. >>> >>> >>> On Wed, Feb 1, 2012 at 11:50 PM, Kengo TODA <[email protected]> wrote: >>>> Hello. >>>> >>>> I'm finding automated checker for SLF4J like PMD ruleset or Findbugs >>>> plugin. >>>> Because I want to pick up bad codes like: >>>> - giving wrong class to LoggerFactory#getLogger(Class) (maybe >>>> copy-pasted from other class) >>>> - using static variable instead of instance variable to store Logger >>>> - calling LoggerFactory#getLogger in method >>>> >>>> I've googled but cannot find it. >>>> Is there already developed one? Or, I have to develop it by own? >>>> >>>> >>>> Thank you for your time. >>>> Kengo TODA >>>> >>>> -- >>>> *** >>>> Kengo TODA (eller86) >>>> [email protected] >>>> http://skypencil.jp/ >>> >>> >>> >>> -- >>> *** >>> Kengo TODA (eller86) >>> [email protected] >>> http://skypencil.jp/ >>> _______________________________________________ >>> slf4j-user mailing list >>> [email protected] >>> http://mailman.qos.ch/mailman/listinfo/slf4j-user >> _______________________________________________ >> slf4j-user mailing list >> [email protected] >> http://mailman.qos.ch/mailman/listinfo/slf4j-user > > > > -- > *** > Kengo TODA (eller86) > [email protected] > http://skypencil.jp/ -- *** Kengo TODA (eller86) [email protected] http://skypencil.jp/ _______________________________________________ slf4j-user mailing list [email protected] http://mailman.qos.ch/mailman/listinfo/slf4j-user
