> jericho     01/05/15 10:14:10
>
>   Modified:    src/webdav/client/src/org/apache/webdav/lib/properties
>                         LockDiscoveryProperty.java
>                src/webdav/client/src/org/apache/webdav/lib/methods
>                         DepthSupport.java
>   Added:       src/webdav/client/src/org/apache/webdav/lib/properties
>                         ActiveLockProperty.java
>   Log:
>   - Rewrite the lockdiscovery and activelock properties.
>   - Change the DEPTH_INFINITY constant to 2.
>     When the getDepth failed, it return -1.

-1 for this patch.

Rationale is :
- Active lock is not a property. To be consistent, I think you should create
a Lock object similar to the Privilege object.
- This patch is not very respectful for my work. I spent a lot of time
integrating the UI code, and this API change breaks the build. While it
needs more work, if you change the API, you should at least make sure it
still builds fine.

For all these reasons, I'll revert the patch.

Remy

Reply via email to