pnever      2002/07/13 09:59:19

  Modified:    src/share/org/apache/slide/macro MacroImpl.java
  Log:
  Added a comment to removeHiddenRevisions().
  
  Revision  Changes    Path
  1.29      +10 -7     jakarta-slide/src/share/org/apache/slide/macro/MacroImpl.java
  
  Index: MacroImpl.java
  ===================================================================
  RCS file: /home/cvs/jakarta-slide/src/share/org/apache/slide/macro/MacroImpl.java,v
  retrieving revision 1.28
  retrieving revision 1.29
  diff -u -r1.28 -r1.29
  --- MacroImpl.java    11 Jul 2002 14:57:08 -0000      1.28
  +++ MacroImpl.java    13 Jul 2002 16:59:18 -0000      1.29
  @@ -572,8 +572,6 @@
                   contentHelper.create(token, destinationUri,
                                        currentRevisionDescriptor,
                                        currentRevisionContent);
  -                
  -                
               }
               // TODO : Parse stack
               // Algorithm :
  @@ -711,6 +709,12 @@
        * revisions only at 0.0.
        */
       private void removeHiddenRevisions( SlideToken token, String targetUri ) throws 
ServiceAccessException, ObjectNotFoundException, LinkedObjectNotFoundException, 
AccessDeniedException, ObjectLockedException {
  +        
  +        // Can this piece of code be moved to MoveMethod.afterDelete() and 
DeleteMethod.afterDelete?
  +        // It would look more consistent (the copying of hidden revisions is 
there!!)
  +        // BUT: I dont think it's a good idea because the deleteObject() method 
would delete
  +        // the NRDS while hidden revisions remain.
  +        
           try {
               contentHelper.remove(token, targetUri, NodeRevisionNumber.HIDDEN_0_0 );
           }
  @@ -718,7 +722,6 @@
               // ignore
           }
       }
  -    
   }
   
   
  
  
  

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to