Hi,

Testing J2EEStore with new db schema shows me some problems :

-> Class org.apache.slide.store.impl.rdbms.J2EEStore should not be
    abstract anymore.

-> There is a referential integrity violation on method
    removeRevisionDescriptors who tries to remove a revision_history
    without removing revision that point to it.
    So (if foreign key contraint is ok) revision entry has to be removed
    before revision_history one and referenced revision_property entries
    are needing too to be removed before.
    Modifying J2EEStore to do what said above does not help : I got an
    ObjectNotFoundException (/users) on slide's initialization.
    If JEEStore with old schema is not breaking RevisionDescriptorsStore
    I will have to swith back to it for now :-(

While looking at this Store, I has some ideas :

-> Why is ids cache completely cleared when full ? Don't you think it
    would be better to clear only ids not used since a long time and keep
    the one most recently used ?

-> It think that table slide_label has not reason to exist.
    It is only referenced by slide_revision_label so adding a string
    label field to slide_revision_label would avoid to have to perform
    one more request (or a join).
    I agree that indexes with integers are a lot better than string ones
    but this is only usefull for keys used by sql request and not a
    reason to add a new table and request for each string data.
    There is exactly the same problem with slide_qname table.


Regards

Jp


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to