Hello Ingo, Eric, I would be OK with me to have the same behavior between HttpClient and the xxxMethod classes, this is both packages expect the URLs already encoded. This way we would not need to make assumptions about the encoding being used (utf-8 or not).
As we are changing the semantical interface of those methods we need to vote on this. If OK with you I will use Eric's arguments. Best regards, Juergen -----Original Message----- From: Ingo Brunberg [mailto:[EMAIL PROTECTED] Sent: Freitag, 1. August 2003 10:16 To: [EMAIL PROTECTED] Subject: Re: encoding in the Webdav client Hello Juergen, > Hello Eric, > > This implication was not obvious to me, sorry if I have created any > inconvenience. > I am currently trying to get the I18N test suite up and running again (xml > test suite with t-processor). During those tests I noticed, that the URL is > not encoded any more during transport to the server. > > The new HttpClient expects all URLs already encoded, it does no extra > encoding. > The WebDAV client API did the encoding as a service for the calling API, at > least some time ago. To my understanding, I thought those were the patches > applied to e.g. PutMethod described in the mentioned e-mails (the path > received in the PutMethod constructor is now utf-8 encoded). > > I think we should discuss our expectations about the xxxMethod classes: > > 1) Would those classes convert ALL urls to UTF-8 > 2) Would those classes convert NO urls to UTF-8 [this is the way HttpClient > works] > 3) Would some methods of those classes convert urls to UTF-8. To me it makes sense, that to be some sort of compatible with Httpclient, the additional WebDAV methods in the Slide client should expect already encoded paths, too. This way a user working directly with Httpclient does not have to distinguish between the different methods. To make this more clear I have also deprecated Slide client's HeadMethod, GetMethod, PutMethod and PostMethod. Do you see any reason why we would need them any more, provided you agree with the above statement? The other thing is when you are working with WebdavResource. In that case you have to pass the unencoded/unescaped paths to the methods defined therein, because WebdavResource does the encoding for you. And this makes perfect sense to me, too. Regards, Ingo > > I will remove my changes. Would it create a big problem, if this is done on > Monday (as I will be at my computer again only late today)? > > Best regards > > Juergen > > > > -----Original Message----- > From: Eric Johnson [mailto:[EMAIL PROTECTED] > Sent: Donnerstag, 31. Juli 2003 20:28 > To: Slide Developers Mailing List > Cc: [EMAIL PROTECTED] > Subject: Re: cvs commit: > jakarta-slide/src/webdav/client/src/org/apache/webdav/lib/methods > GetMethod.java HeadMethod.java HttpRequestBodyMethodBase.java > MkcolMethod.java PutMethod.java UnlockMethod.java > > Juergen, > > If I'm not mistaken, your patch completely breaks the changes that Ingo > Brunberg and I have been wrestling with for the past month. You can > review my emails on the topic here: > > http://archives.apache.org/eyebrowse/[EMAIL PROTECTED] > he.org&msgNo=7205 > http://archives.apache.org/eyebrowse/[EMAIL PROTECTED] > he.org&msgNo=7222 > http://archives.apache.org/eyebrowse/[EMAIL PROTECTED] > he.org&msgNo=7352 > > Overridding setPath() to encode the contents causes all sorts of things > to break. The assumption by HttpClient and derived methos should be > that the parameter passed to the constructors for any method is > *already* encoded. I have confirmed that my application completely > falls apart with the latest changes. > > I kindly request that you roll back your changes and submit a patch to > the group for review. > > -Eric. > > [EMAIL PROTECTED] wrote: > > >juergen 2003/07/31 09:15:19 > > > > Modified: src/webdav/client/src/org/apache/webdav/lib/methods > > GetMethod.java HeadMethod.java > > HttpRequestBodyMethodBase.java MkcolMethod.java > > PutMethod.java UnlockMethod.java > > Log: > > some more fixes for I18N support. The URL passed to the webdav layer (of > http) will be automatically converted into utf-8. > > > > Revision Changes Path > > 1.19 +35 -25 > jakarta-slide/src/webdav/client/src/org/apache/webdav/lib/methods/GetMethod. > java > >
