Hello,
nice to see how much Slide has evolved since 1.0.16.
Caching, Events, ACL, ... great!

While testing it I found an issue if we map the WebdavServlet to an
other path than / by setting the default-servlet parameter in web.xml
to false and mapping the servlet to e.g. /ABC/*.


In the functional test case the folowing occurs


   LOCK method and PROPFIND method
    .../principal-URL/href contains a wrong uri

   PROPPATCH
    /multistatus/response/href contains uri missing the servlet path

   SEARCH
    results un BAD REQUESTs

in ACL test cases some errors occur too, which I have not yet
checked


PROPPATCH can simply fixed with the patch at the end of this mail.



For the other points the reason seems to be a wrong usage of


   public static String getAbsolutePath (String uri, String contextPath,
                                         String servletPath,
                                         WebdavServletConfig config)
   from WebdavUtils.java

which is often called in PropertyHelper.java as

   WebdavUtils.getAbsolutePath (revisionDescriptors.getUri(), contextPath,
                                serverURL, sConf)).

i.e. instead of the expected servletPath is the serverURL provided, which
leads to wrong URIs.

Is there someone working on this or should I dive somewhat deeper to
fix this?

Regards, Stefan


--- PropPatchMethod.java 26 Feb 2004 15:45:55 -0000 1.77 +++ PropPatchMethod.java 8 Mar 2004 17:25:59 -0000 @@ -54,6 +54,7 @@ import org.apache.slide.webdav.util.UriHandler; import org.apache.slide.webdav.util.VersioningHelper; import org.apache.slide.webdav.util.ViolatedPrecondition; +import org.apache.slide.webdav.util.WebdavUtils; import org.apache.slide.webdav.util.resourcekind.AbstractResourceKind; import org.apache.slide.webdav.util.resourcekind.CheckedInVersionControlled; import org.apache.slide.webdav.util.resourcekind.ResourceKind; @@ -467,7 +468,7 @@ Element response = new Element(E_RESPONSE, DNSP); multistatus.addContent(response); Element href = new Element(E_HREF, DNSP); - href.setText(getFullPath(requestUri)); + href.setText(WebdavUtils.getAbsolutePath(requestUri, req, getConfig())); response.addContent(href);

// Parse the two properties list, and printout their status



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to