Thomas, adding your patches to bugzilla would be great.
thanks Stefan
Thomas Draier wrote:
hi,
back with my encoding problems, when using strange characters in filenames ..
i've made some tests on differents servers/platforms/clients - my base config is a tomcat 5.0.27 on mac os, i've also tested with tomcat 4.1.29, and moved the server to a windows xp. as clients, i used windows explorer, webdrive (from south river), cadaver on mac os, and the mac os finder webdav client (almost unusable because of specific mac encoding), cadaver on linux, and konqueror on linux. of course, each configuration gave me different results :-)
the getPathInfo() method is supposed to return a decoded path - but the behaviour is different between different containers when strange characters are sent. tomcat 4 and 5 do no return the same value. i replaced it with a parsing of getRequestURI(), which returns what the client has sent without decoding - and do the same with either tomcat 4 or 5, hopefully also for other servers.
i've also found some problems with the urlEncoding configuration parameter. even if the system is configured as utf-8, some clients can still send a mix of utf-8 and another encoding - so i added another parameter in Configuration to define if utf8 should be used or not, and kept the other as a "secondary" encoding. i changed the decodeString method (the method i previously added), which decodes either utf-8 or encoding specified in the configuration. and i updated the fixTomcatURL() method in order to work with these changes.
i changed the propfind method so that the encoding declared in the xml response match the encoding being used (it was always returning "utf-8")
the "Destination" header should be decoded as the url - for all the clients i've tested, the same form is used - getHeader() works as getRequestURI(), and does not decode anything. i do not know about the "Label" header - the clients i have, except slide client, do not support it now.
finally, i added a transformation for the ? character. that character does not work with most of the client i've used, but it appears if a character not supported by the encoding specified in confguration is sent. and then make the file unusable.
now that seems to work fine, whatever the server, client, or encoding being used .. for what i've tested .. but i'm sure we can still find some other problems :-)
there are 5 modified files - slide.properties, Configuration, AbstractWebdavMethod, PropFindMethod and WebdavUtils - can i send the patches here or on the bugzilla ?
thomas
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
