On Fri, 2004-10-15 at 03:57, Oliver Zeigermann wrote: > Sorry for being late in giving feedback... > > First of all I think it is great how fast you learned how to do all > this. It took me much longer. Thanks for doing this, I really appreciate it!
Thanks for the compliment, it's appreciated :) > > Here are my comments: > > (1) In the README the Tomcat number was 5.0.38 instead of 5.0.28. I > changed it, hope that is ok... Thanks for catching that. Would have been embarrasing :). > > (2) I guess you do not already know, the KEYS file is at > > http://www.apache.org/dist/jakarta/slide/KEYS > > resp. > > /www/www.apache.org/dist/jakarta/slide/KEYS > > You should have access rights... Ok, that should be updated now. > > (3) Do not forget to update > > http://jakarta.apache.org/slide/download.html > > and > > http://jakarta.apache.org/slide/news.html > > as well. > > (4) I checked the Tomcat bundle and it worked fine for me. Have you been > able to find out about the patch problem with server.xml? I have no idea what's going on with this. For the time being I just manually modified the file, but it's really strange. I even made my own patch and tried to apply that and it failed. > > (5) The source release (of the server) looks funny to me. I would have > expected something you can unpack and compile from scratch like in > 2.1b1. The one for 2.1b2 only contains the src directory, no build, no > docs and no libs. Maybe I have a funny understanding of a source > release. What do others think? All I did was run the release target with ant, so I claim no responsibility for what was generated :D. You're absolutely right though, so I looked at the 2.1b1 release and modified the build script so the results match a bit better. There are a lot of files in the root of the 2.1b1 release that I wasn't sure should be included (past release notes and stuff). Can you check the new archive and make sure I haven't missed anything that should be there? One thing to note, the default and target builds projector, so I included it in the source release. Let me know if I missed anything else. -James > > Thanks again :) > > Oliver > > James Mason schrieb: > > http://cvs.apache.org/dist/jakarta/slide/2.1b2/ > > > > I haven't updated the KEYS file yet, but everything is uploaded and > > signed. If some of you have the time I would appreciate some sanity > > checking to make sure I haven't missed anything. > > > > If all goes well I'll update the jakarta-site2 module tonight and send > > out an announcement. > > > > -James > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
