Please correct me if I'm wrong but it seems that versioning helper
suffers from a little bug in the update method. The webDAV spec mentions
that all dead properties of previous VR should be copied to VCR in case
of uncheckout. So a call is made to update from the uncheckout method.
The comments say that the dead properties are being copied from VR to
VCR but the code "says" something else. Please see proposed patch for
this and tell me if I'm wrong. For me this bug as been introduced when
ResourceKind were introduced.
If things are OK I can file this in bugzilla and post patch.
However, i'd lik eto mention that it's the fourth patch I submit since a
few months and none of them have been integrated...... Again, I'm a bit
worried about slide dev team, is it still alive ?
Fabrice
Index: VersioningHelper.java
===================================================================
RCS file:
/home/cvspublic/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelper.java,v
retrieving revision 1.118
*diff -u -r1.118 VersioningHelper.java*
*--- VersioningHelper.java 25 Feb 2005 16:57:55 -0000 1.118*
*+++ VersioningHelper.java 21 Oct 2005 13:39:38 -0000*
@@ -1578,7 +1578,7 @@
while (propertyEnum.hasMoreElements()) {
NodeProperty p = (NodeProperty)propertyEnum.nextElement();
//if( !p.isLiveProperty() ) {
- if (resourceKind.isSupportedLiveProperty(p.getPropertyName())) {
+ if (!resourceKind.isSupportedLiveProperty(p.getPropertyName())) {
vcrRevisionDescriptor.setProperty(p);
}
}
--
Fabrice Dewasmes
Responsable du domaine urbanisation des systèmes d'information
[EMAIL PROTECTED]
06.89.88.65.37
--
Open Wide
14 rue Gaillon
75002 PARIS
www.openwide.fr
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
