The api looks good to me, but :) I have some minor comments: - RequestParameter and RPMap are in a sub package while RequestPathInfo is not. As they both contain additional request information, I think they should either be all three in the core package or all three in the same sub package.
- I think we should move the request and response wrapper into a sub package as usually a developer does not need them. - RequestPathInfo#getSelector(int) is imho not need. To get the number of selectors I have to call getSelectors() which returns all and if I want to iterate of the selectors I can just directly call getSelectors(). - I'm not sure if "helpers" is a good name for its contents (but I'm currently lacking a better name) Carsten Felix Meschberger (JIRA) wrote: > [ > https://issues.apache.org/jira/browse/SLING-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531716 > ] > > fmeschbe edited comment on SLING-28 at 10/26/07 2:17 AM: > ------------------------------------------------------------------ > > Commited first proposal in Rev. 581158 as project sling-api in trunk. > > The new API can be summarized as follows: > > - The API is renamed to Sling API and all prefixes changed to Sling... > - Moved the API to the root Sling package org.apache.sling > - The Component interfaces has been dropped and replaced by just using the > Servlet interface > - An abstract SlingServlet is added, which has a method taking SlingRequest > and SlingResponse > - No special Context and Session implementation any more (just use the > ServletContext and HttpSession) > - SlingResponse is empty: getNamespace is dropped, the other methods are > Servlet API 2.4 replicas > - Require Servlet API 2.4 > - Use servlet name (Servlet.getServletName) as identifier of servlets for > Sling > - Rename Content.getComponentId() to Content.getServletName() method > referring to handling servlet > > Up for discussion .... > > was (Author: fmeschbe): > Commited first proposal in Rev. 581158 as project sling-app in trunk. > > The new API can be summarized as follows: > > - The API is renamed to Sling API and all prefixes changed to Sling... > - Moved the API to the root Sling package org.apache.sling > - The Component interfaces has been dropped and replaced by just using the > Servlet interface > - An abstract SlingServlet is added, which has a method taking SlingRequest > and SlingResponse > - No special Context and Session implementation any more (just use the > ServletContext and HttpSession) > - SlingResponse is empty: getNamespace is dropped, the other methods are > Servlet API 2.4 replicas > - Require Servlet API 2.4 > - Use servlet name (Servlet.getServletName) as identifier of servlets for > Sling > - Rename Content.getComponentId() to Content.getServletName() method > referring to handling servlet > > Up for discussion .... > >> Simplify the Sling (aka Component) API >> -------------------------------------- >> >> Key: SLING-28 >> URL: https://issues.apache.org/jira/browse/SLING-28 >> Project: Sling >> Issue Type: Improvement >> Components: API >> Reporter: Felix Meschberger >> Assignee: Felix Meschberger >> Priority: Blocker >> Fix For: 2.0.0 >> >> >> JIRA issue to track simplification of the Sling (aka Component) API. >> See http://www.mail-archive.com/[email protected]/msg00177.html >> for the discussion on the mailing list. > -- Carsten Ziegeler [EMAIL PROTECTED]
