[ 
https://issues.apache.org/jira/browse/SLING-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615153#action_12615153
 ] 

Bertrand Delacretaz commented on SLING-475:
-------------------------------------------

I tested the latest sling475.patch (2008-07-20 11:40 AM) and it does indeed 
test the sling:include tag with addSelector.

It would be better to use node values in the included scripts (include.jsp and 
selector.jsp), i.e. output some currentNode.something properties and verify 
their values in the test case. This would verify that those scripts act on the 
expected nodes.

Also, I would suggest storing the scripts under 
resources/integration-test/jsp/sling-include in the source code tree, to 
separate them from the others.

> Create Integration tests for the sling:include tag
> --------------------------------------------------
>
>                 Key: SLING-475
>                 URL: https://issues.apache.org/jira/browse/SLING-475
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Scripting JSP
>            Reporter: Felix Meschberger
>         Attachments: PatchWithError.patch, SLING-475.patch, sling475.patch, 
> sling475.patch, Sling475_simple_patch.patch, working.patch
>
>
> Summary says it all ;-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to