[ https://issues.apache.org/jira/browse/SLING-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710635#action_12710635 ]
Felix Meschberger commented on SLING-977: ----------------------------------------- Thanks for submitting the patch. Apart from some formatting issues (of which I will take care), I have a few remarks: * The event classes are named AuthoizableEvent and SynchronousAuthoizableEvent, I assume there is a missing "r", right ? * The topic is just the name of the event class. How about including the operation, such that we get the org/apache/sling/jackrabbit/usermanager/event/update, etc. * How about moving the constants to a public interface and make the constants public ? Since they are used as the names of event properties to be consumed by EventHandlers I think this would make sense. > Add Events to the UserManager Post Servlets > ------------------------------------------- > > Key: SLING-977 > URL: https://issues.apache.org/jira/browse/SLING-977 > Project: Sling > Issue Type: Improvement > Affects Versions: JCR Jackrabbit User Manager 2.0.2 > Reporter: Ian Boston > Attachments: SLING-977.patch > > > In many situations when a user is created a number of there are a number of > things content structures that an application will want to create. Adding > Sychronous OSGi events to the crud methods in the UserManager servlets will > allow this to happen. Access to those events should be managed inside the > OSGi framework as per the R4.1 spec, since in the patch to follow the > privileged session is handed thought the event. > The second use case is to have an async event of the information about the > operation without any objects that need to remain bound to the request > thread. These will allow auditing of the user management process to be handed > off to another bundle. > Patch to follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.