Mark Stosberg wrote:
> Christopher Browne wrote:
>   
>> Mark Stosberg <[EMAIL PROTECTED]> writes:
>>     
>>> Using Slony 1.2.6, when  I try
>>>
>>>   SELECT _production.generate_sync_event('10 minutes');
>>>
>>> I get:
>>>
>>>     schema ""_production"" does not exist.
>>>
>>>
>>> It seems to get quoted too many times.  The schema definitely exists.
>>> This works:
>>>
>>>   SELECT _production.sl_status;
>>>
>>> This is on FreeBSD 4.10 with PostgreSQL 8.1. Perhaps there's an issue
>>> with this OS having an older toolchain?
>>>       
>> There may still be a quoting problem in this :-(.  There was one a while 
>> back...
>>
>> Hmm.  Obviously I need to add a regression test for this.  That ought
>> to keep this problem down...
>>     
>
> I there are some related recent 'commits' for this in CVS now. Is it
> expected to be safe to put "CVS HEAD" into production now, or should I
> wait for the next release, or try to apply just this related patches?
>   
I'm anticipating releasing a 1.1.7 and 1.2.7 Real Soon Now; if you look
in the respective release notes files, you'll see the bugs that they
address.

I reported a bug on Saturday that I plan to address in both branches, too.

I would absolutely NOT recommend using CVS HEAD for production; I would
instead suggest considering what will soon become 1.2.7.
> Thanks for the patches, Christopher. I looked into trying to add an
> automated test for this, but I think I'll need to wait for the
> test-writing HOWTO before I feel comfortable with the customized test suite.
>   
Take a look at the code I added to tests/test1/generate_dml.sh; I did
one for each stored function that I wanted to test.  It should be
straightforward enough to see the point:
 - It runs the query against the master DB
 - It checks the return code from the psql command; errors generate
non-zero $? values
 - It reports an error, if need be, and that'll cause the test to be
considered failed.

[EMAIL PROTECTED]:CMD/slony1-HEAD/tests/test1> tail -17 generate_dml.sh
  fi
  status "data load complete"

  $pgbindir/psql -h $host -p $port -d $db -U $user -c "select
\"_${CLUSTER1}\".generate_sync_event('1 second'::interval);" 1>
$mktmp/gensync.log.1 2> $mktmp/gensync.log
  rc=$?
  if [ $rc -ne 0 ]; then
      warn 3 "generate_sync_event() failed - rc=${rc} see
$mktmp/gensync.log* for details"
  fi
  status "completed generate_sync_event() test"
  $pgbindir/psql -h $host -p $port -d $db -U $user -c "select
\"_${CLUSTER1}\".make_function_strict('xxidin', '(cstring)');" 1>
$mktmp/gensync.log.1 2> $mktmp/gensync.log
  rc=$?
  if [ $rc -ne 0 ]; then
      warn 3 "make_function_strict('xxidin', '(cstring)') failed -
rc=${rc} see $mktmp/gensync.log* for details"
  fi
  status "completed make_function_strict() test"
  status "done"
}

_______________________________________________
Slony1-general mailing list
[email protected]
http://gborg.postgresql.org/mailman/listinfo/slony1-general

Reply via email to