On 11/27/13 02:51, Janne Blomqvist wrote:
On 2013-11-25 18:38, Jason Bacon wrote:
A few patches are attached. I'm withholding additional patches to
task_cgroup_cpuset.c pending further testing with FreeBSD's hwloc.
Not that it's my decision to make, but IMHO since cgroups are
(extremely) Linux-specific, rather than making an #ifdef mess out of
the cgroup plugin, it would be better to create a separate task/hwloc
plugin.
Thanks for the suggestion. I agree with keeping #ifdefs to a minimum.
I'll keep this in mind when I get to that point. A FreeBSD jails plugin
might be a good option to provide some of the cgroups plugin
functionality down the road.
Right now I'm focused on testing basic functionality to make sure it's
rock solid ASAP. Most of the basic features seem to work and the
patches for FreeBSD have been minimal. It was a remarkably easy port
considering the size and complexity of the code. My compliments to the
developers...
Happy Thanksgiving,
JB
