On Thu, Mar 5, 2015 at 11:19 AM, Pär Lindfors <[email protected]> wrote:
> > Manu Thambi <[email protected]> writes: > > > The following commit (which is included in version 14.11.4) seems to > > make > > stdout buffered when --unbuffered is passed in, which seems wrong. > ... > > "seems wrong" is an understatement. I honestly thought I did not read > your e-mail correctly the first time. > > This is completely messed up. Please SchedMD, commit > 064cdb5eb6ea95ca23b1d5118b96dd04aa4c7e06 needs to be reverted! > > If no option like this had existed before, then due to the principle of > least surprise it would be quite bad to name it "--unbuffered" when what > it does is to set line buffered output. > I have to agree. If anything, I would recommend: a) revert the change b) fix (clarify) the manpage c) add new options to set line and block (specify a size) buffered modes explicitly. Here is my reasoning: 1. --unbuffered setting buffered is a POLA violation. The switch does the opposite of what it says it does. 2. 10+ years of existing behavior 3. With regards to (c), you get the ability to set the buffering the way you want without having to change any existing software. Full control (as much as is possible, anyway) is returned to the invoker and no backwards-incompatible changes are made. -- Jon Nelson Dyn / Senior Software Engineer p. +1 (603) 263-8029
