Hi all,
Not much feedback on my previous post however here again but I make
it shorter :-)
Before Slurm 14.11, it was allowed to set a default priority to jobs
through the job submit plugin API. Since Slurm 14.11, it is not
possible anymore.
From the slurm.conf man
JobSubmitPlugins
A comma delimited list of job submission plugins to be used.
The
specified plugins will
be executed in the order listed. These are intended to be
site-specific plugins which
can be used to set default job parameters and/or logging
events. …
Is the job submit plugin supposed to allow to set a default
priority therefore it would be a bug or does the plugin allow to set
default job parameters but the priority is not included in such
parameters therefore, it would be considered as a new restriction
that will be kept in any future release ?
Thanks
Nicolas
On 23/09/2015 20:38, Nicolas Bertolus
wrote:
Hi all,
We are currently planning to move from Slurm 2.6.9 to 14.11 and
so, we have setup a test environment to confirm that our local
tools work fine. However, we have found that our job submit plugin
cannot set the initial priority anymore.
Since Slurm 2.2, we are using the job submit plugin API to
set/modify some default job parameters. One of them is the initial
priority of the job. This priority is then updated over time with
an external tool therefore, the priority plugin is the default
(priority/basic). This setup works fine for us since the
implementation with Slurm 2.2 and obviously, our preference would
be to keep this setup if possible.
The change was introduced with the following commit
https://github.com/SchedMD/slurm/commit/2a17983d38fa0f30deb80d9868eb9f0d593f55a9.patch
+ -- In the job_submit plugin: Remove all slurmctld locks prior
tojob_submit()
+being called for improved performance. If any slurmctld data
structures are
+read or modified, add locks directly in the plugin.
Since Slurm 14.11
_slurm_rpc_allocate_ressources/_slurm_rpc_job_will_run/_slurm_rpc_submit_batch_job/
validate_job_create_req
job_submit_plugin_submit <<< initial
priority setup
job_allocate
_job_create
if ((submit_uid != 0) && (submit_uid !=
slurmctld_conf.slurm_user_id)
job_desc->priority = NO_VAL;
Priority is reset when job is submit by normal users.
Before Slurm 14.11
_slurm_rpc_allocate_ressources/_slurm_rpc_job_will_run/_slurm_rpc_submit_batch_job/
validate_job_create_req
job_allocate
_job_create
if ((submit_uid != 0) && (submit_uid !=
slurmctld_conf.slurm_user_id)
job_desc->priority = NO_VAL;
job_submit_plugin_submit <<< initial
priority setup
From the commit, it doesn't look like that it was the plan to
change the behavior but just perf improvement therefore, I guess
this is not intentional to prevent the job submit plugin to
set/update the job priority.
Is it possible to restore the possibility for the job submit
plugin to set/modify the job priority in the next releases or is
it something that will not be allow anymore in the future
releases.
Thanks,
Nicolas
