I agree with Marcel. Error on the side of caution here. :-)
On Tue, Jul 8, 2014 at 11:44 AM, Marcel Telka via illumos-developer < [email protected]> wrote: > Hi, > > Nice work. Please find my comments inline. > > On Tue, Jul 08, 2014 at 01:43:36PM -0400, Youzhong Yang via > illumos-developer wrote: > > I made the following two changes and built a new image, the issue goes > away. > > > > --- a/usr/src/uts/common/klm/nlm_impl.c > > +++ b/usr/src/uts/common/klm/nlm_impl.c > > @@ -525,6 +525,12 @@ nlm_clnt_call(CLIENT *clnt, rpcproc_t procnum, > > xdrproc_t xdr_args, > > */ > > if (procnum >= NLM_TEST_RES && procnum <= NLM_GRANTED_RES) > > wait = nlm_rpctv_zero; > > + if (procnum == NLM_NULL) { > > + wait.tv_sec = 0; > > + wait.tv_usec = 25000; > > + } > > + > > > > --- a/usr/src/uts/common/klm/nlm_rpc_handle.c > > +++ b/usr/src/uts/common/klm/nlm_rpc_handle.c > > @@ -55,6 +55,7 @@ > > (_status) == RPC_PROGVERSMISMATCH || \ > > (_status) == RPC_PROCUNAVAIL || \ > > (_status) == RPC_CANTCONNECT || \ > > + (_status) == RPC_TIMEDOUT || \ > > (_status) == RPC_XPRTFAILED) > > > > Please add the following (or similar) note as a comment close to your > modification in nlm_clnt_call() so the explanation why we do need to > adjust the > default timeout is retained for future. > > > Setting timeout value of NULL rpc to 25 milliseconds instead of the > default > > 25 seconds can make nlm_null_rpc() returns RPC_TIMEDOUT after 1575 > > milliseconds when the UDP port is not reachable: > > 1575 = 25 + 50 + 100 + 200 + 400 + 800 => 5 retries > > In general, this should work, but I'm not sure your suggestion of 25 ms > (for > the initial timoeut) and 1.5 sec (as the total timeout) is long enough. > Assuming the client (Mac OS) rebooted. The reboot is slow operation, so > there > is no need to be so fast (1.5 sec) in detecting it. I think we should > push the > total timeout to ca 30 seconds (with the initial timeout at 0.5 sec) or > maybe > even more to avoid spurious stale clients detection. > > > Thank you. > > -- > +-------------------------------------------+ > | Marcel Telka e-mail: [email protected] | > | homepage: http://telka.sk/ | > | jabber: [email protected] | > +-------------------------------------------+ > > > ------------------------------------------- > illumos-developer > Archives: https://www.listbox.com/member/archive/182179/=now > RSS Feed: > https://www.listbox.com/member/archive/rss/182179/21239177-3604570e > Modify Your Subscription: > https://www.listbox.com/member/?&; > Powered by Listbox: http://www.listbox.com > ------------------------------------------- smartos-discuss Archives: https://www.listbox.com/member/archive/184463/=now RSS Feed: https://www.listbox.com/member/archive/rss/184463/25769125-55cfbc00 Modify Your Subscription: https://www.listbox.com/member/?member_id=25769125&id_secret=25769125-7688e9fb Powered by Listbox: http://www.listbox.com
