On 05/09/10 14:58, Julian Taylor wrote:
> - the testcases produce build errors when the backend dependencies are
> not met (added patch to tracker)

Julian,

I have applied fix for this error, however it's different
than the patch.

My idea is that backend registration for CMake is self-contained
and enables/disables backend automatically, without any external
if-def conditions. It means, the following line:

soci_backend(...)

determines if required dependencies are available and enables
and configures backend, or disables it. Thus, the following:

if (WITH_SQLITE3) # or SQLITE3_FOUND
   soci_backend(...)
endif()

is redundant.

The fix I've applied based on (e.g.
src/backends/sqlite3/test/CMakeLists.txt):

if (SQLITE3_FOUND)

# setup test

endif()

is also temporary [1] and it will be replaced with either extension in
soci_backend() macro automatically registering test along backend
or with separate macro soci_backend_test() which similarly to
soci_backend() will take care of determining availability of required
dependencies.

[1]
http://soci.git.sourceforge.net/git/gitweb.cgi?p=soci/soci;a=blob;f=src/backends/sqlite3/test/CMakeLists.txt;h=e2666078934bde3f657cbe78c00f601b6afc4647;hb=88840027499ed58a9c9ff406b0bb158fe7a76e04#l1

Here is example of expected output reporting missing dependencies, so
disabled backend and its tests:

http://www.flickr.com/photos/mloskot/4983187419/
http://www.flickr.com/photos/mloskot/4983188061/

I hope it makes sense.

Thank you for testing and patching!

Best regards,
-- 
Mateusz Loskot, http://mateusz.loskot.net
Charter Member of OSGeo, http://osgeo.org

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Soci-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/soci-users

Reply via email to