Hi, I'd like to kindly suggest a few best practices to anyone who is submitting a Pull Request t to GitHub.
It's a good idea to keep Pull Requests as narrow as possible. In order to do that, topic branches are used to isolate changes. This is Git, so branching is cheap, easy and pleasant :) The important thing to understand on GitHub is that you can only submit one Pull Request per branch (in local clone) If you want to submit fixes/patches for number of (unrelated) features/backends/etc., you would be best if you can submit multiple Pull Requests. But, to be able to do it, you will have to use multiple branches, one branch per topic/fix. Small concise Pull Requests are easier to review and submit, and they are less likely to introduce bugs uncaught during review. All this speeds things up, hopefully :) Big cheers for your pull requests! Here are some helpful references: 1) Must read https://help.github.com/articles/using-pull-requests 2) Clear and short quick tutorial https://openshift.redhat.com/community/wiki/github-workflow-for-submitting-pull-requests 3) More discussions http://gun.io/blog/how-to-github-fork-branch-and-pull-request/ http://stackoverflow.com/questions/8450036/how-to-open-multiple-pull-requests-on-github http://stackoverflow.com/questions/7523557/submitting-multiple-pull-requests-in-git-with-github-general-flow p.s. If I find a moment, I may start "Submitting pull requests to SOCI" wiki at https://github.com/SOCI/soci/wiki Best regards, -- Mateusz Loskot, http://mateusz.loskot.net ------------------------------------------------------------------------------ LogMeIn Central: Instant, anywhere, Remote PC access and management. Stay in control, update software, and manage PCs from one command center Diagnose problems and improve visibility into emerging IT issues Automate, monitor and manage. Do more in less time with Central http://p.sf.net/sfu/logmein12331_d2d _______________________________________________ Soci-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/soci-users
