On 1 April 2015 at 14:59, Vadim Zeitlin <[email protected]> wrote: > On Fri, 27 Mar 2015 18:25:04 +0100 Mateusz Loskot <[email protected]> wrote: > > ML> On 27 March 2015 at 17:53, Vadim Zeitlin <[email protected]> wrote: > ML> > ML> > My favourite solution would be to just move the tests one level up in > the > ML> > file system, i.e. get rid of the subdirectory completely. But we could > also > ML> > keep the hierarchy and just rename it to something else, especially if > ML> > somebody has any good proposals for the subdirectory name ("catch" > doesn't > ML> > count, because it doesn't really matter what do the tests use for their > ML> > checks, the name should rather describe what do they do and not how). > ML> > ML> Two options which are equally good to me: > ML> 1. Move tests/assert/* one level up to tests/ > ML> 2. Rename tests/assert to tests/{system|functional|integrate}, which may > open > ML> the structure for other test categories (e.g. plain unit tests that > ML> don't test backends functional > ML> integration with any physical DB env). > ML> > ML> Please, choose whichever suits you. > > In the absence of any objections/other proposals, I chose (1) and > merged my catch-tests branch in develop now. I didn't have time to further > reorganize the tests yet because I wanted to submit > https://github.com/SOCI/soci/pull/302 as soon as possible, as this is what > we really need, but I hope to do it in the future.
Vadim, It looks very good. Thank you for your efforts! > I think that ideal would be to stop building all the different > soci_xxx_test programs and build just a single soci_test which would > integrate all the backends and run the common tests for all of them by > default -- but allow to choose just a single (or several) backend(s) to use > from the command line. But this would require a lot of changes... This is an interesting idea and I support it. It would simplify maintenance and CMake configuration Do you mind to open an Issue for that? I'm not sure how to combine common and specific tests for all backends with CATCH, but I can do CMake clean up. Best regards, -- Mateusz Loskot, http://mateusz.loskot.net ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ soci-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/soci-users
