Anant Gole wrote:
> TI HECC (High End CAN Controller) module is found on many TI devices. It
> has 32 hardware mailboxes with full implementation of CAN protocol 2.0B
> with bus speeds up to 1Mbps. Specifications of the module are available
> on TI web <http://www.ti.com>
>
> Signed-off-by: Anant Gole <[email protected]>
Unfortunately, there are still a few coding style issues. e.g.:
- Multi line comments should look like:
/*
* Line 1
* Line 2
*/
- Don't use brackets without good reasons:
a = b + c; instead of
a = (b + c);
Examples:
can_btc = ((bit_timing->phase_seg2 - 1) & 0x7);
hecc_write(priv, HECC_CANGIM,
(HECC_CANGIM_DEF_MASK | HECC_CANGIM_I0EN));
- Use just *one* tab for indention:
} else if (priv->rx_next > HECC_RX_BUFFER_MBOX) {
break; /* pkt not received yet */
}
Apart from that, the patch now looks good from the Socket-CAN point of
view. Please cleanup and resubmit to the netdev and arm-kernel ML as well.
Wolfgang.
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
